Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only the first instance of insecure content is fixed #138

Closed
1 task done
kmgalanakis opened this issue Aug 17, 2023 · 0 comments · Fixed by #139
Closed
1 task done

Only the first instance of insecure content is fixed #138

kmgalanakis opened this issue Aug 17, 2023 · 0 comments · Fixed by #139
Assignees
@kmgalanakis
Labels
type:bug Something isn't working.
Milestone
1.2.0

Comments

@kmgalanakis
Copy link
Contributor

kmgalanakis commented Aug 17, 2023 •
edited
Loading

Describe the bug

When having a post with multiple different insecure content instances, when the button to fix the first one is fixed every attempt to fix one of the other instances fails. Same for the highlighting.

Steps to Reproduce

  1. Create a post with this content
<!-- wp:image {"sizeSlug":"large"} -->
<figure class="wp-block-image size-large"><img src="http://cdn.pixabay.com/photo/2015/06/19/21/24/avenue-815297_960_720.jpg" alt=""/></figure>
<!-- /wp:image -->

<!-- wp:image {"sizeSlug":"large"} -->
<figure class="wp-block-image size-large"><img src="https://cdn.pixabay.com/photo/2016/09/07/16/19/pile-1651945_1280.jpg" alt=""/></figure>
<!-- /wp:image -->

<!-- wp:image {"sizeSlug":"large"} -->
<figure class="wp-block-image size-large"><img src="https://cdn.pixabay.com/photo/2014/08/15/11/29/beach-418742_1280.jpg" alt=""/></figure>
<!-- /wp:image -->

<!-- wp:paragraph -->
<p>aaa</p>
<!-- /wp:paragraph -->
  1. Try to save the post
  2. Click the button to fix the first one, it gets fixed without issues.
  3. Click the button to fix the second and the third one. Each attempt should fail to fix the content without any visible errors

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kmgalanakis kmgalanakis added the type:bug Something isn't working. label Aug 17, 2023
@kmgalanakis kmgalanakis self-assigned this Aug 17, 2023
@kmgalanakis kmgalanakis moved this from Incoming to In Progress in Open Source Practice Aug 17, 2023
@kmgalanakis kmgalanakis added this to the 1.2.0 milestone Aug 17, 2023
@kmgalanakis kmgalanakis mentioned this issue Aug 17, 2023
Merged
4 tasks
@jeffpaul jeffpaul moved this from In Progress to In Review in Open Source Practice Aug 17, 2023
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmgalanakis kmgalanakis

Labels
type:bug Something isn't working.
Projects
Open Source Practice
Archived in project
Milestone
1.2.0
1 participant
@kmgalanakis