Merged
Conversation
jeffpaul
requested review from
a team and
cadic
and removed request for
a team and
jeffpaul
cadic
suggested changes
Oct 13, 2022
| "minimum-stability": "dev", | ||
| "require": { | ||
| "php": ">=5.4" | ||
| "php": ">=7.4" |
There was a problem hiding this comment.
I wonder is 7.4 a real requirement within the codebase of this plugin? 7.0-7.3 still take more than 20% of setups according to WordPress Stats
Member
Member
There was a problem hiding this comment.
@cadic that sound ok to you or should we stick with 7.0?
cadic
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Bumped up WP and PHP minimums. Also having some issues with the README.MD file formatting while saving so skipped that file to update the version numbers.
Closes #93
Changelog Entry
Added - Bumped up WordPress and PHP Minimums
Credits
Props @jeffpaul @zamanq
Checklist: