-
Notifications
You must be signed in to change notification settings - Fork 8
fix commands to work from WP 5.7 to 6.4 #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
87204a3 to
b6fe370
Compare
7be0122 to
a8b4e22
Compare
iamdharmesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sidsector9 Tests are passing on the GH action and PR LGTM. just added one minor comment to discuss. once it is concluded we are good to merge this.
Thanks for fixing this.
Co-authored-by: Dharmesh Patel <[email protected]>
|
@Sidsector9 @iamdharmesh is the |
|
The WP Latest test failures are intermittent both locally and in the GH Actions. Running in the browser I am seeing some issues with the rendering of the editors iframe but I am unsure if that is happening in the GH actions too. In the most recent push, the first run fails with In the second run both Similar happening elsewhere. |
23dd0c9 to
81178fc
Compare
|
@peterwilsoncc I've taken a look at this and whilst I can't replicate the error locally, I do see the following in the artifacts from the latest GH Actions failure: This seems to me that something is causing the editor to fall over. Is there anyway to get more information about general JS errors rather than Cypress specific errors? That will likely give us more insight into what's going on under the hood. |
|
I've been able to reproduce locally using the electron browser rather than Chrome but not seeing any hints in the console when running |
|
Thanks @peterwilsoncc! Running in Electron I was able to reproduce that error. If I enable
This error points at this line: Interestingly, if you log out
Yet if you log out the extracted
but notice how I'm assuming this is a bug in Electron browser windows, but I'm not sure where that leaves us or this test. |
|
@darylldoyle Thank you! That's a great help. In 9fffc47 I've switched the GitHub actions to use Chrome and will run the test suite a few times to see if it ends up less flaky. It's probably a good thing to do as it better represents what the end user is running and that's the purpose of the test suite. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go now the flakey tests have been resolved by using chrome on GitHub.
It could probably do with another approval as I've pushed a few changes:
- updated winamp plugin
- modified plugin test to allow for versions of WP unsupported by the plugin
|
cc: @iamdharmesh we've switched back to Chrome 😄 |
fix commands to work from WP 5.7 to 6.4




Description of the Change
This PR:
insertBlock,createPostandopenDocumentSettingSidebarscommands.check-block-pattern-exists.test.jstoz.check-block-pattern-exists.test.jsas the order of this test affects the outcome of other tests. (I couldn't figure out the reason yet.)How to test the Change
Confirm in the E2E log if this command passes in the 3 WP versions.
Changelog Entry
Credits
Props @Sidsector9
Checklist: