Add a workflow to build a release asset #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
reviewed
Oct 18, 2023
| @@ -23,8 +23,7 @@ | |||
| "node": ">=12.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "10up-toolkit": "^5.2.1", | |||
| "eslint-plugin-prettier": "^5.0.0" | |||
There was a problem hiding this comment.
Looks like this bit might still be needed by the JS linting, yeah?
There was a problem hiding this comment.
Yeah, realized that by having this here, you always have to run a force npm install, which I didn't love. Opened a new PR to address this for our eslint workflow: #25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Similar to what we do on other plugins, this PR adds a GitHub Action that will build a release asset anytime the Action is requested or on merges to
trunk. The main reasoning for this is to build the plugin prior to release and then run tests on that built version locally.Closes #15
How to test the Change
Hard to test until this is merged in
Changelog Entry
Credits
Props @dkotter
Checklist: