Try: Run E2E tests on generated release zip #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
approved these changes
Dec 2, 2022
Contributor
Sidsector9
left a comment
Sidsector9
left a comment
There was a problem hiding this comment.
Thanks for working on this!
It is a helpful addition, looks good to me!
dkotter
approved these changes
Dec 2, 2022
This was referenced Dec 14, 2022
Closed
This was referenced Dec 22, 2022
Run E2E tests on the zip generated by "Build release zip" action.
10up/insert-special-characters#176
Closed
Closed
Closed
Closed
Closed
Closed
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
PR contains changes to Run E2E tests on the zip generated by "Build release zip" action to catch release zip bugs early and at the PR level instead of manual testing before release.
How to test the Change
I tried deleting the
.distignorefile to generate a zip without the vendor folder and verified that the E2E tests fail.Changelog Entry
Credits
Props @iamdharmesh
Checklist: