Merged
Conversation
Member
|
@cadic what else remains here to open this for review/merging? Not looking to get full coverage, just getting something here would be good. |
Member
|
@cadic pinging again here to see if there's more to get this up for review/merge? |
cadic
requested review from
a team and
faisal-alvi
and removed request for
a team
faisal-alvi
previously approved these changes
Nov 18, 2022
phpunit.xml.dist
Outdated
Comment on lines
3
to
9
| bootstrap="tests/unit/bootstrap.php" | ||
| backupGlobals="false" | ||
| colors="true" | ||
| convertErrorsToExceptions="true" | ||
| convertNoticesToExceptions="true" | ||
| convertWarningsToExceptions="true" | ||
| verbose="true" |
Contributor
There was a problem hiding this comment.
seems like an extra tab?
Contributor
Author
There was a problem hiding this comment.
@faisal-alvi thank you, fixed that in 556b11e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds PHP Unit tests
Changelog Entry
Added - Unit tests