Skip to content

Comments

Remove unused echo before esc_html_e()#186

Merged
dkotter merged 1 commit into10up:developfrom
Soean:remove_unused_echo
Mar 13, 2025
Merged

Remove unused echo before esc_html_e()#186
dkotter merged 1 commit into10up:developfrom
Soean:remove_unused_echo

Conversation

@Soean
Copy link
Contributor

@Soean Soean commented Mar 13, 2025

Description of the Change

esc_html_e already echos text and don't return any value.

Changelog Entry

Removed - unused echo before esc_html_e()

Credits

Props @Soean

Checklist:

@Soean Soean requested review from dkotter and jeffpaul as code owners March 13, 2025 17:00
@jeffpaul jeffpaul added this to the 1.5.0 milestone Mar 13, 2025
@jeffpaul jeffpaul moved this to Code Review in Open Source Practice Mar 13, 2025
@jeffpaul jeffpaul requested review from peterwilsoncc and removed request for dkotter and jeffpaul March 13, 2025 17:02
Copy link
Collaborator

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@github-project-automation github-project-automation bot moved this from Code Review to QA Testing in Open Source Practice Mar 13, 2025
@dkotter dkotter merged commit b766d17 into 10up:develop Mar 13, 2025
8 of 12 checks passed
@github-project-automation github-project-automation bot moved this from QA Testing to Done in Open Source Practice Mar 13, 2025
@Soean Soean deleted the remove_unused_echo branch March 14, 2025 06:51
@dkotter dkotter modified the milestones: 1.5.0, 1.4.6 Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants