Cypress integration migrated to 11+#116
Merged
peterwilsoncc merged 2 commits intodevelopfrom Jan 11, 2023
Merged
Conversation
Member
|
@jayedul is there any additional work here or can this PR move out of draft and come up for review? |
Contributor
Author
There was a merge conflict since develop branch updated later. Now it has been resolved and marked as ready for review. |
peterwilsoncc
approved these changes
Jan 11, 2023
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
LGTM, thanks 👍
Testing notes:
npm ias expectednpm env:startas expectednpm cypress:runas expectednpm cypress:openas expected (ran each spec individually)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Cypress integration migrated to 11+
Closes #114
How to test the Change
npm run cypress:runto test without GUInpm run cypress:opento test with GUIChangelog Entry