Repository navigation
Skip /Annots entries that have no valid /Subtype - #128
Merged
0xabu merged 2 commits intoNov 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page's
/Annotsarray refers to a dictionary that isn't an annotation, pdfannots stops with:I hit this with
tests/resources/test_2861.pdffrom PyMuPDF (from pymupdf/PyMuPDF#2861), a published paper. Its first page's/Annotslists a link's action dictionary (/S /URI) and its border array next to the two/Linkannotations. The border array already gives an empty dict and is skipped, but the action dictionary reaches_mkannotation()without a/Subtype._mkannotation()now logs a warning and returnsNonefor such an entry, like it does for an unsupported subtype, and the rest of the page is read.I didn't add the paper itself as a test file (copyright, and an author's e-mail address in it).
tests/annots-entries-without-subtype.pdfhas the same structure, made with pypdf: a border array, an action dictionary and a Text annotation in/Annots. TheAnnotsEntriesWithoutSubtypetest checks that the Text annotation is extracted; it fails on main.pytest tests.py,mypy .,flake8 pdfannots tests.pyandautopep8 --diffpass.Used Claude (Opus) to help find and patch this; I reviewed and tested the change