Repository navigation
Resolve an annotation's /Subtype and /Contents when they are indirect objects - #125
Merged
0xabu merged 1 commit intoNov 8, 2026
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A text annotation whose
/Contentsis an indirect object makes the whole run fail:and an indirect
/Subtypestops atassert isinstance(subtype, PSLiteral). Both values may be indirect in a PDF, and_mkannotation()already resolves the other entries it reads (/C,/Rect,/QuadPoints,/T,/NM, the dates) withpdftypes.resolve1(). Now these two are resolved the same way.Added
tests/indirect-objects.pdf(a single text annotation with both values indirect, made with pypdf) and anIndirectObjectstest; it fails on main.pytest tests.py,mypy .,flake8andautopep8 --diffpass.Used Claude (Opus) to help find and patch this; I reviewed and tested the change