Merged
Conversation
mihoward21
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like the async nature of the
onMessageExternalis still brittle/evolving according to codex, the pattern we previously had no longer works because of new changes in chromiums messaging flow. Check out the responses section here: https://developer.chrome.com/docs/extensions/develop/concepts/messagingThis hardens the external runtime bridge used to retrieve stored RPC payloads for large transaction flows. It changes the external message handler to use sendResponse with an explicit async channel return, improving compatibility with runtime messaging behavior. It also broadens sender origin detection to support sender contexts that expose origin rather than URL, while keeping existing origin checks intact. Together this prevents valid payload fetch requests from being rejected or dropped in each send transaction and wallet send calls flows.