Update Application.swift#129
Merged
0xLeif merged 1 commit intocodex/update-docc.yml-and-package.swift-for-spm-pluginfrom Jun 4, 2025
Merged
Update Application.swift#1290xLeif merged 1 commit intocodex/update-docc.yml-and-package.swift-for-spm-pluginfrom
0xLeif merged 1 commit intocodex/update-docc.yml-and-package.swift-for-spm-pluginfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds @MainActor isolation to the static logger property in Application.swift to ensure main‐actor confinement for logging on supported platforms.
- Annotate
loggerwith@MainActor - Change applies only on non-Linux and non-Windows builds under the existing conditional
Comments suppressed due to low confidence (1)
Sources/AppState/Application/Application.swift:17
- Marking a global logger as
@MainActorwill force every logging call from background threads to hop to the main actor, which may introduce unnecessary context switches. Consider whether actor isolation is required for the logger, or if the underlying logging API is already thread-safe and can be left unannotated.
@MainActor
0xLeif
merged commit 13dd74c
into
codex/update-docc.yml-and-package.swift-for-spm-plugin
3 checks passed
0xLeif
added a commit
that referenced
this pull request
Jun 7, 2025
* Run documentation workflow on every push * Update docc.yml * Update docc.yml * Update docc.yml * Update Application.swift (#129) * Update macOS.yml * Update macOS.yml * Update ubuntu.yml * Update docc.yml * Update ubuntu.yml * Fix docc workflow (#130) * Fix docc workflow * Update docc.yml * Update ubuntu.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.