Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up deprecated API methods, updates licensing, and modernizes CI workflows.
- Removes deprecated
remove(storedState:)andremove(syncState:)methods inApplication+public.swift - Updates the license year from 2024 to 2025
- Upgrades Windows CI to Swift 6.1 and Ubuntu CI to
ubuntu-latest
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/AppState/Application/Application+public.swift | Deletes two deprecated remove methods renamed to reset |
| LICENSE | Bumps copyright year to 2025 |
| .github/workflows/windows.yml | Adds checkout step, sets up Swift 6.1 with branch and tag |
| .github/workflows/ubuntu.yml | Changes runner from ubuntu-20.04 to ubuntu-latest |
Comments suppressed due to low confidence (2)
.github/workflows/windows.yml:10
- The initial Swift setup action appears unconfigured and is duplicated later; consider removing this step or pinning a specific version, and ensure
actions/checkout@v4runs first for consistency.
- - uses: compnerd/gha-setup-swift@main
.github/workflows/windows.yml:18
- [nitpick] The
tagkey has extra spaces; aligning its indentation with other keys would improve readability.
tag: 6.1-RELEASE # exact toolchain tag
| jobs: | ||
| build: | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
[nitpick] Switching to ubuntu-latest can bring unexpected environment changes; consider pinning to a specific release (e.g., ubuntu-22.04) to guarantee build consistency.
Suggested change
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-22.04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.