Repository navigation
fix(nginx): read the log level only from a bracketed tag in nginx output - #2074
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetLogLevellooked for each level name anywhere in the nginx output, so a word that only appears in the message counted as the level. A[warn]line that names a host or path containingalert,critorerrorwas read as that higher level, andControlResult.IsError()(level aboveWarn) then reported a successfulnginx -tas a failure:IsErrorgates config saves ininternal/config/transaction.go,internal/snippet,internal/streamand the managed upstream store, so with a server name like that every save was treated as a failed test. The same happens with a path such as/etc/nginx/sites-enabled/error-pages.confin a[warn]line, and output with no level at all that mentions/var/log/nginx/error.logwas read asError.nginx always writes the level in brackets (
nginx: [emerg] ...,2026/11/02 12:00:00 [error] ...), so the fix matches[level]instead of the bare word. It still returns the highest level found, and the existing constant tests ([debug]through[emerg], plusUnknownfor untagged text) pass unchanged.Tests:
TestGetLogLevelIgnoresLevelNamesInsideTheMessageandTestControlResultIsNotErrorForWarnOutputNamingAnAlertHostfail before the change and pass after.go test -count=1 ./internal/nginx/passes, and gofmt andgo vetare clean.AI disclosure: written with an AI coding assistant. I reproduced the misread level before the change and checked the tests fail without the fix myself.