t0005: skip signal death exit code test on Windows

j6t · gitster · commit 04422c74c88e · 2013-06-06T10:22:52.000-07:00
The test case depends on that test-sigchain can commit suicide by a
call to raise(SIGTERM) in a way that run-command.c::wait_or_whine()
can detect as death through a signal. There are no POSIX signals on
Windows, and a sufficiently close emulation is not available in the
Microsoft C runtime (and probably not even possible).

The particular deficiency is that when a signal is raise()d whose
SIG_DFL action will cause process death (SIGTERM in this case), the
implementation of raise() in msvcrt just calls exit(3).

We could check for exit code 3 in addition to 143, but that would
miss the point of the test entirely. Hence, just skip it on Windows.

Signed-off-by: Johannes Sixt &lt;j6t@kdbg.org&gt;
Acked-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t0005-signals.sh b/t/t0005-signals.sh
@@ -20,7 +20,7 @@ test_expect_success 'sigchain works' '
 	test_cmp expect actual
 '
 
-test_expect_success 'signals are propagated using shell convention' '
+test_expect_success !MINGW 'signals are propagated using shell convention' '
 	# we use exec here to avoid any sub-shell interpretation
 	# of the exit code
 	git config alias.sigterm "!exec test-sigchain" &&

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ test_expect_success 'sigchain works' '`
`20`	`20`	`test_cmp expect actual`
`21`	`21`	`'`
`22`	`22`
`23`		`-test_expect_success 'signals are propagated using shell convention' '`
	`23`	`+test_expect_success !MINGW 'signals are propagated using shell convention' '`
`24`	`24`	`# we use exec here to avoid any sub-shell interpretation`
`25`	`25`	`# of the exit code`
`26`	`26`	`git config alias.sigterm "!exec test-sigchain" &&`