Repository navigation
Conversation
nightblure
changed the title
nightblure
changed the title
kemingy
approved these changes
Apr 9, 2025
kemingy
left a comment
kemingy
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! 🎉
Contributor
Author
|
Thanks for such a quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi!
having pydantic v2 I wouldn't want to call the
dictmethod for at least two reasons:dictmethod and after moving to v2 it would be logical to rename it tomodel_dump. Without this change I'll have to debug the spectree code before I understood that my method with the new name won't be calledp.s.
noqa: SIM108it's a matter of taste, I can change it to a ternary operator as the linter suggests, if you want that too