fix(server): avoid transient GitHub mergeability sync churn#22022

Approvability

Verdict: Approved at 6c1dca7

Macroscope's review found this PR approvable — The reactor retains known GitHub mergeability during transient unknown responses, avoiding redundant snapshot updates and stack reads. The behavior is limited to open PRs with unchanged timestamps and does not alter merge operations or permissions.

^{You can add or adjust custom eligibility rules. Learn more.}

Review in Change Stack →

No actionable comments were generated in the recent review.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Integrated main d36b7da2485bc889b320a285deea181f637d760a in c44d0674bda947e5fd62733175cb82c0423ac1f6 with a normal descendant push. Known GitHub mergeability is retained through an unchanged PR’s transient unknown window while current avatar-token identity handling and stack sync remain intact. Updated the regression to main’s five-minute quiet-PR cadence and asserted both actual summary reads. All 37 focused tests and targeted lint pass; imported ACP type diagnostics remain.

Focused tests: 37 passed (37); exit 0. Targeted lint exit 0. Focused typecheck exit 1. Diagnostics: packages/provider-acp/src/server/AcpSessionRuntime.ts(1334,29): error TS2339: Property 'signal' does not exist on type 'AcpProcessExitedError'.; packages/provider-acp/src/server/AcpSessionRuntime.ts(1334,68): error TS2339: Property 'signal' does not exist on type 'AcpProcessExitedError'.; packages/provider-acp/src/server/adapter.ts(3302,49): error TS2339: Property 'error' does not exist on type '{ readonly sessionUpdate: "state_update"; readonly state: "idle"; readonly stopReason?: string | null; readonly usage?: Usage | null; readonly _meta?: Meta; }'.; packages/provider-acp/src/server/adapter.ts(4449,32): error TS2339: Property 'error' does not exist on type '{ readonly sessionUpdate: "state_update"; readonly state: "idle"; readonly stopReason?: string | null; readonly usage?: Usage | null; readonly _meta?: Meta; }'.; packages/provider-acp/src/server/adapter.ts(4450,40): error TS2339: Property 'error' does not exist on type '{ readonly sessionUpdate: "state_update"; readonly state: "idle"; readonly stopReason?: string | null; readonly usage?: Usage | null; readonly _meta?: Meta; }'.; packages/provider-acp/src/server/adapter.ts(4451,30): error TS2339: Property 'error' does not exist on type '{ readonly sessionUpdate: "state_update"; readonly state: "idle"; readonly stopReason?: string | null; readonly usage?: Usage | null; readonly _meta?: Meta; }'. No browser/device verification was run.

Fresh current-head CI/review and all existing product, maintainer, and native-evidence gates remain. Upstream permission is READ; the parent owns watches and merges.

Verified in a real dev environment

partial verification at 6c1dca77f28717761193416227202f08d81e2ece, on a linux boat vm. ran github/main (575579d68a) in a separate worktree first, stopped its background server, then ran the exact pr head with isolated state. used repository playwright and /usr/bin/google-chrome, app-created projects and threads, and real codex gpt-6.1-sol turns. the turns completed on main and the pr head.

linked this github pr through the app, opened its live detail, and ran ten actions → refresh iterations. github summaries stayed mergeable with updatedAt=2026-10-31T07:23:50Z; the persisted snapshot-update count stayed at three across the two links. a new link initially persisted unknown and then mergeable, as expected when there is no prior known snapshot.

vp run check:changed 50c1c5dc536493826fc66e220598f38b831d5bde passed through blacksmith: format, lint, knip, graphql, affected typechecks, and 53 tests. the 52 focused reactor tests also passed. no source changes or pushes.

runtime command transcript

live pr detail after a completed codex turn and refresh

https://uploads-production-47e4.up.railway.app/files/8b2e0f1e-2a61-4e7d-9a2a-999276f7152f/pr22022-refresh.mp4

recording playback and seeking were checked in chrome; github may expose this external recording as a link rather than an inline player.

Not verified

the core known → unknown → same-known regression remains unverified in the real app. main never exhibited that sequence, and github never returned unknown for an already-known snapshot during the pr-head refresh observations. the initial unknown → known transition does not prove suppression. github controls recomputation; no mocks, forced responses, base pushes, or external pr mutations were used to manufacture it. passing tests and stable refreshes are not evidence that the live flap was suppressed.

native ios/android clients, electron shells, and forgejo were not exercised on this linux vm.