Skip to content

Instantly share code, notes, and snippets.

@EliahKagan
Last active September 5, 2024 19:52
Show Gist options
  • Select an option

  • Save EliahKagan/823a06406ede7fdbc8ea71afb8405dcd to your computer and use it in GitHub Desktop.

Select an option

Save EliahKagan/823a06406ede7fdbc8ea71afb8405dcd to your computer and use it in GitHub Desktop.
gix-testtools configure_command() with unpaired high surrogate
ek@Glub MINGW64 ~/source/repos/gitoxide/tests/tools (main)
$ git diff
diff --git a/tests/tools/src/lib.rs b/tests/tools/src/lib.rs
index b3c0102ea..127e7cab1 100644
--- a/tests/tools/src/lib.rs
+++ b/tests/tools/src/lib.rs
@@ -595,6 +595,7 @@ fn configure_command<'a>(
) -> &'a mut std::process::Command {
let mut msys_for_git_bash_on_windows = std::env::var("MSYS").unwrap_or_default();
msys_for_git_bash_on_windows.push_str(" winsymlinks:nativestrict");
+ panic!("DEBUG: {msys_for_git_bash_on_windows:?}"); // FIXME: Remove after debugging.
cmd.args(args)
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
ek@Glub MINGW64 ~/source/repos/gitoxide/tests/tools (main)
$ MSYS='error_start:nonexistent' cargo nextest run configure_command_clears_external_config
warning: unreachable expression
--> tests\tools\src\lib.rs:599:5
|
598 | panic!("DEBUG: {msys_for_git_bash_on_windows:?}"); // FIXME: Remove after debugging.
| ------------------------------------------------- any code following this expression is unreachable
599 | / cmd.args(args)
600 | | .stdout(std::process::Stdio::piped())
601 | | .stderr(std::process::Stdio::piped())
602 | | .current_dir(script_result_directory)
... |
623 | | .env("GIT_CONFIG_KEY_3", "protocol.file.allow")
624 | | .env("GIT_CONFIG_VALUE_3", "always")
| |____________________________________________^ unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
warning: unused variable: `cmd`
--> tests\tools\src\lib.rs:592:5
|
592 | cmd: &'a mut std::process::Command,
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
|
= note: `#[warn(unused_variables)]` on by default
warning: unused variable: `args`
--> tests\tools\src\lib.rs:593:5
|
593 | args: &[String],
| ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
warning: unused variable: `script_result_directory`
--> tests\tools\src\lib.rs:594:5
|
594 | script_result_directory: &Path,
| ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_script_result_directory`
warning: `gix-testtools` (lib) generated 4 warnings
warning: `gix-testtools` (lib test) generated 4 warnings (4 duplicates)
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.39s
------------
Nextest run ID e36b5636-bba9-47d5-b9d5-0ae20e5c0f30 with nextest profile: default
Starting 1 test across 3 binaries (6 tests skipped)
FAIL [ 0.015s] gix-testtools tests::configure_command_clears_external_config
--- STDOUT: gix-testtools tests::configure_command_clears_external_config ---
running 1 test
test tests::configure_command_clears_external_config ... FAILED
failures:
failures:
tests::configure_command_clears_external_config
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.01s
--- STDERR: gix-testtools tests::configure_command_clears_external_config ---
thread 'tests::configure_command_clears_external_config' panicked at tests\tools\src\lib.rs:598:5:
DEBUG: "error_start:nonexistent winsymlinks:nativestrict"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Canceling due to test failure
------------
Summary [ 0.017s] 1 test run: 0 passed, 1 failed, 6 skipped
FAIL [ 0.015s] gix-testtools tests::configure_command_clears_external_config
error: test run failed
ek@Glub MINGW64 ~/source/repos/gitoxide/tests/tools (main)
$ MSYS=$'error_start:\uD800z' cargo nextest run configure_command_clears_external_config
warning: unreachable expression
--> tests\tools\src\lib.rs:599:5
|
598 | panic!("DEBUG: {msys_for_git_bash_on_windows:?}"); // FIXME: Remove after debugging.
| ------------------------------------------------- any code following this expression is unreachable
599 | / cmd.args(args)
600 | | .stdout(std::process::Stdio::piped())
601 | | .stderr(std::process::Stdio::piped())
602 | | .current_dir(script_result_directory)
... |
623 | | .env("GIT_CONFIG_KEY_3", "protocol.file.allow")
624 | | .env("GIT_CONFIG_VALUE_3", "always")
| |____________________________________________^ unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
warning: unused variable: `cmd`
--> tests\tools\src\lib.rs:592:5
|
592 | cmd: &'a mut std::process::Command,
| ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
|
= note: `#[warn(unused_variables)]` on by default
warning: unused variable: `args`
--> tests\tools\src\lib.rs:593:5
|
593 | args: &[String],
| ^^^^ help: if this is intentional, prefix it with an underscore: `_args`
warning: unused variable: `script_result_directory`
--> tests\tools\src\lib.rs:594:5
|
594 | script_result_directory: &Path,
| ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_script_result_directory`
warning: `gix-testtools` (lib) generated 4 warnings
warning: `gix-testtools` (lib test) generated 4 warnings (4 duplicates)
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.39s
------------
Nextest run ID bc896e5b-fabd-45b5-8823-4889319cf522 with nextest profile: default
Starting 1 test across 3 binaries (6 tests skipped)
FAIL [ 0.024s] gix-testtools tests::configure_command_clears_external_config
--- STDOUT: gix-testtools tests::configure_command_clears_external_config ---
running 1 test
test tests::configure_command_clears_external_config ... FAILED
failures:
failures:
tests::configure_command_clears_external_config
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.02s
--- STDERR: gix-testtools tests::configure_command_clears_external_config ---
thread 'tests::configure_command_clears_external_config' panicked at tests\tools\src\lib.rs:598:5:
DEBUG: " winsymlinks:nativestrict"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Canceling due to test failure
------------
Summary [ 0.026s] 1 test run: 0 passed, 1 failed, 6 skipped
FAIL [ 0.024s] gix-testtools tests::configure_command_clears_external_config
error: test run failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment