Make WordPress Core

Opened 12 days ago

Closed 11 days ago

#64869 closed defect (bug) (fixed)

Admin Reskin: The visibility icon in the password field is misaligned

Reported by: wildworks's profile wildworks Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: normal Version: trunk
Component: Login and Registration Keywords: admin-reskin has-patch commit
Focuses: Cc:

Description

On the login screen, the visibility icon in the password field is positioned slightly lower than it should be. I think this line-height value should be 1.

Attachments (1)

hide-pw-eye.png (37.3 KB) - added by wildworks 12 days ago.
Comparison of the actual position of the icon and its expected position

Download all attachments as: .zip

Change History (6)

@wildworks
12 days ago

Comparison of the actual position of the icon and its expected position

@niravsherasiya7707 commented on PR #11270:


12 days ago
#2

Test adding again for the core trac image visibility


Before
https://github.com/user-attachments/assets/91da9402-cd3f-4f1b-b3b7-da924918abf0

After
https://github.com/user-attachments/assets/f806e9a7-a2ea-4535-8b76-c662a2c0f0cc

#3 @khushi1501
12 days ago

Tested this on WordPress 7.0 Beta 5.

I was able to reproduce the issue before applying the patch. After applying the patch, the issue appears to be resolved and the behavior is now working as expected.

Before applying the patch:-
https://prnt.sc/0LrWqNowFcJA

After applying the patch:-
https://prnt.sc/mqx5UoxW2Tet

#4 @joedolson
11 days ago

  • Keywords commit added
  • Owner set to joedolson
  • Status changed from new to accepted
  • Version set to trunk

Looks good!

#5 @joedolson
11 days ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 62038:

Login and Registration: Fix password icon alignment.

Change the line-height of the button element for toggling password visibility to center the icon vertically.

Props wildworks, niravsherasiya7707, khushi1501, joedolson.
Fixes #64869.

Note: See TracTickets for help on using tickets.