Make WordPress Core

Opened 3 weeks ago

Last modified 3 weeks ago

#64303 new defect (bug)

Editor: sync latest packages to trunk

Reported by: ellatrix's profile ellatrix Owned by:
Milestone: 7.0 Priority: normal
Severity: normal Version: 6.9
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

Now that 6.9 has been branched, we should try to keep the Gutenberg packages up-to-date in trunk, to be synced every GB release every two weeks. It could be even more often: sync RC every two weeks and then stable on the other weeks in between.

Change History (7)

@jonsurrell commented on PR #10551:


3 weeks ago
#3

I've pushed two commits to backport necessary changes from https://github.com/WordPress/gutenberg/pull/72485.

These were required because the @wordpress/interactivity module changed
wpScriptModuleExports in its package.json and removed an exposed module.

There was some special handling in place for its debug module that had to be removed.

@youknowriad it would be great if you could take a look at the backports I've added to this PR.

@jonsurrell commented on PR #10551:


3 weeks ago
#4

There's a remaining failure unrelated to Interactivity or Modules:

There was 1 failure:

1) Tests_Blocks_Render::test_do_block_output with data set #6 ('core__categories.html', 'core__categories.server.html')
File '/var/www/tests/phpunit/includes/../data/blocks/fixtures/core__categories.html' does not match expected value
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<ul class="wp-block-categories-list wp-block-categories"><li class="cat-item-none">No categories</li></ul>'
+'<ul class="wp-block-categories-list wp-block-categories-taxonomy-category wp-block-categories"><li class="cat-item-none">No categories</li></ul>'

@jonsurrell commented on PR #10551:


3 weeks ago
#5

The categories class change appears to be from https://github.com/WordPress/gutenberg/pull/72662.

The categories block index.php changed across these packages:

  • index.php

    1 2 function render_block_core_categories( $attributes, $content, $block ) { 
    7979                }
    8080        }
    8181
    82         $wrapper_attributes = get_block_wrapper_attributes( array( 'class' => "wp-block-categories-{$type}" ) );
     82        $wrapper_attributes = get_block_wrapper_attributes( array( 'class' => "wp-block-categories-{$type} wp-block-categories-taxonomy-{$attributes['taxonomy']}" ) );
    8383
    8484        return sprintf(
    8585                $wrapper_markup,

I'll push a commit to update the failing test assertion. FYI @ntsekouras.

@ntsekouras commented on PR #10551:


3 weeks ago
#6

I'll push a commit to update the failing test assertion. FYI @ntsekouras.

Thanks. That sounds fine!

@ellatrix commented on PR #10551:


3 weeks ago
#7

Currently the editors are not loading:

Error: You tried to opt-in to unstable APIs as module "@wordpress/dataviews" which is already registered. This feature is only for JavaScript modules shipped with WordPress core. Please do not use it in plugins and themes as the unstable APIs will be removed without a warning. If you ignore this error and depend on unstable features, your product will inevitably break on one of the next WordPress releases.

See https://github.com/WordPress/gutenberg/pull/73554

Note: See TracTickets for help on using tickets.