WordPress.org
Get WordPress

Make WordPress Core

Opened 3 weeks ago

Closed 3 weeks ago

#64302 closed enhancement (fixed)

Composer: update to WordPressCS 3.3.0

Reported by: rodrigosprimo's profile rodrigosprimo Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: coding-standards Cc:

Description

WordPressCS 3.3.0 was released today.

It is recommended for WP Core to update as soon as convenient. The impact on existing core code is expected to be low to non-existent. The release updates some sniffs to account for changes in recent WordPress versions up to 6.9.0-RC2.

Similar to what was done in previous tickets (#60840 and #63762), I opted to update PHPCS as well to the latest compatible version (WPCS is not yet compatible with PHPCS 4.x). The impact of this PHPCS update on core code should also be minimal to non-existent.

Refs:

WPCS:
​https://github.com/WordPress/WordPress-Coding-Standards/releases/tag/3.3.0
​https://github.com/WordPress/WordPress-Coding-Standards/compare/3.2.0...3.3.0

PHPCS:
​https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.13.3
​https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.13.4
​https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.13.5
​https://github.com/PHPCSStandards/PHP_CodeSniffer/compare/3.13.2...3.13.5

Previous: #63762

Props: @jrf, @dingo_d, @garyj, @rodrigosprimo, @johnjago.

Change History (4)

#2 @desrosj
3 weeks ago

  • Milestone changed from Awaiting Review to 7.0

#3 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#4 @SergeyBiryukov
3 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61306:

Coding Standards: Upgrade WPCS to version 3.3.0.

The impact on existing WordPress core code is expected to be minimal. The release updates some sniffs to account for changes in recent WordPress versions up to 6.9.0-RC2.

References:

Follow-up to [56695], [56799], [57378], [57986], [60523].

Props jrf, dingo_d, garyj, rodrigosprimo, johnjago, SergeyBiryukov.
Fixes #64302.

Note: See TracTickets for help on using tickets.