WordPress.org
Get WordPress

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#64253 closed enhancement (fixed)

Update getID3 to version 1.9.24

Reported by: desrosj's profile desrosj Owned by: johnbillion's profile johnbillion
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch fixed-major dev-reviewed
Focuses: Cc:

Description (last modified by desrosj)

Follow up to #64051.

In [60812], two upstream changes were merged into WordPress to improve PHP 8.5 compatibility.

There is now an officially tagged version of the library that includes these two fixes, so the library should be updated to get away from a "detached" state.

The 1.9.24 release is primarily bug fixes, but does include two features:

  • HEIF support has been added to the Quicktime audio/video module.
  • Support for basic GPX file format detection has been added.

Change History (13)

This ticket was mentioned in ​PR #10518 on ​WordPress/wordpress-develop by ​@desrosj.
3 months ago #1

Trac ticket: Core-64253

#2 @desrosj
3 months ago

  • Milestone changed from Awaiting Review to 6.9

While we are in the RC phase of 6.9, I am moving this to the milestone for consideration.

It may be preferable to include an official version of the library instead of a partial one.

#3 @desrosj
3 months ago

  • Description modified (diff)

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
3 months ago

#5 @TobiasBg
3 months ago

Yes, I think this makes sense. The additional code changes are mostly formatting and cleanup, The changes around XML handling are relevant for security, so getting this in is a good idea.

This ticket was mentioned in ​Slack in #core by wildworks. ​View the logs.
3 months ago

#7 @desrosj
3 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 61253:

External Libraries: Update getID3 to version 1.9.24.

In [60812], two changes related to PHP 8.5 compatibility were cherry picked from the upstream repository to be included in time for WordPress 6.9. Since then, a proper release has been tagged which includes several bug fixes in addition to the previous two changes.

HEIF support has also been added to the Quicktime audio/video module.

A full list of changes can be found on GitHub: ​https://github.com/JamesHeinrich/getID3/releases/tag/v1.9.24

Props TobiasBg.
Fixes #64253.

#8 @desrosj
3 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport consideration.

This ticket was mentioned in ​Slack in #core by wildworks. ​View the logs.
3 months ago

#10 @wildworks
3 months ago

This ticket was featured in today's 6.9 Bug Scrub.

@SergeyBiryukov @swissspidy, If you have the bandwidth, could you review it for backporting?

This ticket was mentioned in ​Slack in #core by welcher. ​View the logs.
3 months ago

#12 @johnbillion
3 months ago

  • Keywords dev-reviewed added
  • Owner changed from desrosj to johnbillion
  • Status changed from reopened to accepted

#13 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61289:

External Libraries: Update getID3 to version 1.9.24.

In [60812], two changes related to PHP 8.5 compatibility were cherry picked from the upstream repository to be included in time for WordPress 6.9. Since then, a proper release has been tagged which includes several bug fixes in addition to the previous two changes.

HEIF support has also been added to the Quicktime audio/video module.

A full list of changes can be found on GitHub: ​https://github.com/JamesHeinrich/getID3/releases/tag/v1.9.24

Reviewed by desrosj, SergeyBiryukov.
Merges [61253] to the 6.9 branch.

Props TobiasBg.
Fixes #64253.

Note: See TracTickets for help on using tickets.