WordPress.org
Get WordPress

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 3 months ago

#64051 closed defect (bug) (fixed)

PHP 8.5: Update ID3 library for compatibility

Reported by: swissspidy's profile swissspidy Owned by: swissspidy's profile swissspidy
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: has-patch php85
Focuses: Cc:

Description

Parent ticket for all things PHP 8.5: #63061

PHP 8.5 support was improved upstream in ​https://github.com/JamesHeinrich/getID3/pull/469, but there was also a PR in ​https://github.com/WordPress/wordpress-develop/pull/9605 for the same.

There hasn't been a new release of this library in a long time, and we're unlikely to see one in time for 6.9. We should just patch it ourselves.

There's previous precedent in r46113 prior to the full release in r46166, and r49621 and r50714 before the full release in r51900.

Change History (3)

This ticket was mentioned in ​PR #10082 on ​WordPress/wordpress-develop by ​@swissspidy.
5 months ago #1

Cherry-picks JamesHeinrich/getID3#8cb292333f60be1c0a2ba65acbfdb5f06f174536

Trac ticket: https://core.trac.wordpress.org/ticket/64051

#2 @swissspidy
5 months ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from assigned to closed

In 60812:

External Libraries: Backport upstream PHP 8.5 fixes for getID3.

In absence of a new release, this cherry-picks ​8cb29233 and ​dbda40de.

Props swissspidy, vidugupta, TobiasBg, desrosj.
Fixes #64051. See #63061.

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
3 months ago

Note: See TracTickets for help on using tickets.