Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#59755 closed defect (bug) (fixed)

Term Description (core/term-description) is broken in 6.4-RC2

Reported by: danieldudzic's profile danieldudzic Owned by:
Milestone: 6.4 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: Cc:

Change History (18)

This ticket was mentioned in Slack in #core by danieldudzic. View the logs.


2 years ago

#3 @swissspidy
2 years ago

  • Component changed from General to Editor
  • Keywords close added
  • Severity changed from major to normal

#4 @danieldudzic
2 years ago

@swissspidy I see.

Well, regardless of whether the block should be available with the Gutenberg plugin active only, it does work correctly without the Gutenberg plugin active in 6.3.2.

So now in 6.4, it's a regression.

#6 @swissspidy
2 years ago

  • Keywords close removed
  • Milestone changed from Awaiting Review to 6.4

This ticket was mentioned in Slack in #core-editor by hellofromtonya. View the logs.


2 years ago

#8 @danieldudzic
2 years ago

It seems that the change was made in order to hide the Term Description block from the post editor (and just have it available in the template editor).

But that's not what __experimental": "fse" was meant for.

#9 @hellofromTonya
2 years ago

I can confirm what is reported. In 6.4 within the Site Editor, the block renders as

Your site doesn’t include support for the "core/term-description" block. You can leave this block intact or remove it entirely.

Activating the Gutenberg plugin restores the Term Description block.

Reference:

Though it rendered in the frontend in 6.3, it seems intentional to not render in the frontend in 6.4, as it is experimental.

Thinking more broadly, I'm thinking experimental features and blocks should require the Gutenberg plugin and not render without the plugin. Likely a bugfix happened, though not sure what.

Exploring the differences between 6.3 and 6.4 in Core:

As it did render in the frontend and Site Editor in WP 6.3, something did change in 6.4 to remove support for the experimental block without Gutenberg plugin being activated.

While IMO this is good to not expose experimental blocks/features in Core only, wondering: What changed and is it intentional?

Pinging some folks to hopefully find out @bernhard-reiter @poena.
Pinging the 6.4 editor tech leads for awareness @mikachan @siobhyb @karmatosed.

As noting, if action is required, this will likely need to be reported upstream in Gutenberg.

Last edited 2 years ago by hellofromTonya (previous) (diff)

#10 @huzaifaalmesbah
2 years ago

I checked 6.4-RC2 the term-description block is not available without Gutenberg plugin.

#11 @danieldudzic
2 years ago

For context, this change breaks the Term Description block used in our patterns in WooCommerce Blocks: https://github.com/woocommerce/woocommerce-blocks/issues/11300

If this change is not reverted, 6.4 will cause breakage for users currently using those patterns but not having Gutenberg active.

#13 @poena
2 years ago

There seems to be some confusion about what the property __experimental does in block.json.

"__experimental": "fse" means it is included in the package updates, but the block is only available in site editing context. The Site Editor. This is because these blocks are intended for designing templates, not for content.
They do not work in the post content, this block never printed anything on the front if it was added in the post editor. The term description block has been in core sine 5.9.

"__experimental": true means it is not in Core.
Such as the new form blocks, table of content, time to read.

#14 @swissspidy
2 years ago

@poena that clearly doesn‘t seem to be working as the block is not available in the site editor in 6.4

#17 @hellofromTonya
2 years ago

  • Keywords has-unit-tests removed

Update:

This regression and BC break was fixed in Gutenberg PR 55665 and will be included in the RC3 npm package updates being tracking in #59411.

#19 @hellofromTonya
2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by [57033] on trunk and [57034] on the 6.4 branch.

Note: See TracTickets for help on using tickets.