unittest for wp_upload_bits

Trac ticket: https://core.trac.wordpress.org/ticket/57130
This is isn't working maybe someone else can work why we get this error

1) tests_wp_upload_bits::test_second_parm_present
Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.

[pbearne]

The linked pull request isn't working maybe someone else can work out why we get this error

1) tests_wp_upload_bits::test_second_parm_present
Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.

Trac ticket: https://core.trac.wordpress.org/ticket/57130

There were unit tests in the original PR - ​https://github.com/WordPress/wordpress-develop/pull/2367/files#diff-032b8ca66e0285a30919e60d55165db1e4ab54666b9012512f9e003ca9e07b84

I may have forgotten to commit these 😮‍💨

There were unit tests in the original PR - ​https://github.com/WordPress/wordpress-develop/pull/2367/files#diff-032b8ca66e0285a30919e60d55165db1e4ab54666b9012512f9e003ca9e07b84

I may have forgotten to commit these 😮‍💨

@SergeyBiryukov

Thanks for the PR!

It looks like there were some pre-existing tests for this function added in r52837 and moved to a separate file in r54861.

Keeping the ticket open for now to see if anything from this PR should be added to the existing tests (though at a glance it seems like they are mostly the same), as well as to commit ​some other tests pointed out above.

I believe this is fixed as of r54861 and r54863.

[r1k0]

I believe this is fixed as of r54861 and r54863.

The tests needed are already available, as indicated above. Removing needs-testing, going ahead and closing (wontfix); the PR is closed in GitHub as well.