Changeset 61460

Timestamp:

01/09/2026 08:30:52 PM (3 weeks ago)

Author:

westonruter

Message:

XML-RPC: Update addTwoNumbers demo method to check args prior to adding.

Invalid args now cause an IXR_Error to be returned.

Comprehensive unit tests are also added for the method.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10690

Follow-up to [1348].

Props josephscott, westonruter.
Fixes #64479.

Location:

trunk

Files:

• src/wp-includes/class-wp-xmlrpc-server.php (modified) (2 diffs)
• tests/phpunit/tests/xmlrpc/demo (added)
• tests/phpunit/tests/xmlrpc/demo/addTwoNumbers.php (added)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -263 +263 @@
      * @since 1.5.0
      *
-     * @param array $args {
+     * @param int[] $args {
      *     Method arguments. Note: arguments must be ordered as documented.
      *
@@ -269 +269 @@
      *     @type int $1 A second number to add.
      * }
-     * @return int Sum of the two given numbers.
+     * @return int|IXR_Error Sum of the two given numbers.
      */
     public function addTwoNumbers( $args ) {
+        if ( ! is_array( $args ) || count( $args ) !== 2 || ! is_int( $args[0] ) || ! is_int( $args[1] ) ) {
+            $this->error = new IXR_Error( 400, __( 'Invalid arguments passed to this XML-RPC method. Requires two integers.' ) );
+            return $this->error;
+        }
+
         $number1 = $args[0];
         $number2 = $args[1];