Changeset 61342

Timestamp:

12/01/2025 11:42:12 PM (12 days ago)

Author:

dmsnell

Message:

Block Processor: Remove use of NumberFormatter from test suite.

The Block Processor tests call NumberFormatter for generating its
error messages, but in environments lacking the intl extension this
led to crashes while running the tests.

This patch reworks the tests so that they avoid calling
NumberFormatter so that the tests run on more diverse setups.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10576
Discussed in https://core.trac.wordpress.org/ticket/64329

Follow-up to [60939].

Props desrosj, ellatrix, peterwilsoncc, westonruter.

See #64329.

File:

• trunk/tests/phpunit/tests/block-processor/wpBlockProcessor-BlockProcessing.php (modified) (3 diffs)

trunk/tests/phpunit/tests/block-processor/wpBlockProcessor-BlockProcessing.php

@@ -50 +50 @@
 
         $processor = new WP_Block_Processor( $html );
-        $n         = new NumberFormatter( 'en-US', NumberFormatter::ORDINAL );
 
         for ( $i = 0; $i < $max_depth; $i++ ) {
+            $nth = $i + 1;
+
             $this->assertTrue(
                 $processor->next_delimiter(),
-                "Should have found {$n->format( $i + 1 )} opening delimiter: check test setup."
+                "Should have found opening delimiter #{$nth}: check test setup."
             );
 
@@ -61 +62 @@
                 $i + 1,
                 $processor->get_depth(),
-                "Should have identified the proper depth of the {$n->format( $i + 1 )} opening delimiter."
+                "Should have identified the proper depth of opening delimiter #{$nth}."
             );
         }
 
         for ( $i = 0; $i < $max_depth; $i++ ) {
+            $nth = $i + 1;
+
             $this->assertTrue(
                 $processor->next_delimiter(),
-                "Should have found {$n->format( $i + 1 )} closing delimiter: check test setup."
+                "Should have found closing delimiter #{$nth}: check test setup."
             );
 
@@ -74 +77 @@
                 $max_depth - $i - 1,
                 $processor->get_depth(),
-                "Should have identified the proper depth of the {$n->format( $i + 1 )} closing delimiter."
+                "Should have identified the proper depth of closing delimiter #{$nth}."
             );
         }