Changeset 61252

Timestamp:

11/17/2025 10:56:06 AM (4 weeks ago)

Author:

jorgefilipecosta

Message:

Fix: Core abilities invalid schemas (has examples and returns empty array intested of object).

This commit fixes two issues with the core abilities schemas we have:

• They have examples on the schema with is not complient with the version draft-04 of schema JSON we are using.
• The top level defaults are defined as an empty array and they are of type object, but a php empty array gets JSON serialized and returned in the rest API as [] instead of {}, causing problems on the client validation.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10510.

Props jorgefilipecosta, gziolo.
Fixes #64252.

Location:

branches/6.9

Files:

• . (modified) (1 prop)
• src/wp-includes/abilities.php (modified) (1 diff)
• src/wp-includes/rest-api/endpoints/class-wp-rest-abilities-v1-list-controller.php (modified) (2 diffs)

branches/6.9/src/wp-includes/abilities.php

@@ -221 +221 @@
                         'type'        => 'string',
                         'description' => __( 'The database server vendor and version string reported by the driver.' ),
-                        'examples'    => array( '8.0.34', '10.11.6-MariaDB' ),
                     ),
                     'wp_version'     => array(

branches/6.9/src/wp-includes/rest-api/endpoints/class-wp-rest-abilities-v1-list-controller.php

@@ -196 +196 @@
 
     /**
+     * Normalizes schema empty object defaults.
+     *
+     * Converts empty array defaults to objects when the schema type is 'object'
+     * to ensure proper JSON serialization as {} instead of [].
+     *
+     * @since 6.9.0
+     *
+     * @param array<string, mixed> $schema The schema array.
+     * @return array<string, mixed> The normalized schema.
+     */
+    private function normalize_schema_empty_object_defaults( array $schema ): array {
+        if ( isset( $schema['type'] ) && 'object' === $schema['type'] && isset( $schema['default'] ) ) {
+            $default = $schema['default'];
+            if ( is_array( $default ) && empty( $default ) ) {
+                $schema['default'] = (object) $default;
+            }
+        }
+        return $schema;
+    }
+
+    /**
      * Prepares an ability for response.
      *
@@ -210 +231 @@
             'description'   => $ability->get_description(),
             'category'      => $ability->get_category(),
-            'input_schema'  => $ability->get_input_schema(),
-            'output_schema' => $ability->get_output_schema(),
+            'input_schema'  => $this->normalize_schema_empty_object_defaults( $ability->get_input_schema() ),
+            'output_schema' => $this->normalize_schema_empty_object_defaults( $ability->get_output_schema() ),
             'meta'          => $ability->get_meta(),
         );