Changeset 61199

Timestamp:

11/10/2025 10:49:33 PM (6 weeks ago)

Author:

adamsilverstein

Message:

Notes: refine post author notifications.

Code maintenance follow up to r61179. Move wp_new_comment_via_rest_notify_postauthor callback from REST API Comments controller to comment.php. Add default to wp_notes_notify for multisite compatibility.

Props adamsilverstein, justlevine, mukesh27, mamaduka, peterwilsoncc, desros.
See #64204.

Location:

trunk/src

Files:

• wp-admin/includes/schema.php (modified) (1 diff)
• wp-admin/options-discussion.php (modified) (1 diff)
• wp-includes/comment.php (modified) (2 diffs)
• wp-includes/default-filters.php (modified) (1 diff)
• wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-admin/includes/schema.php

@@ -564 +564 @@
         // 6.9.0
         'wp_notes_notify'                 => 1,
-
     );
 

trunk/src/wp-admin/options-discussion.php

@@ -163 +163 @@
 <br />
 <label for="wp_notes_notify">
-<input name="wp_notes_notify" type="checkbox" id="wp_notes_notify" value="1" <?php checked( '1', get_option( 'wp_notes_notify' ) ); ?> />
+<input name="wp_notes_notify" type="checkbox" id="wp_notes_notify" value="1" <?php checked( '1', get_option( 'wp_notes_notify', 1 ) ); ?> />
 <?php _e( 'Anyone posts a note' ); ?> </label>
 

trunk/src/wp-includes/comment.php

@@ -2428 +2428 @@
     $is_note = ( $comment && 'note' === $comment->comment_type );
 
-    $maybe_notify = $is_note ? get_option( 'wp_notes_notify' ) : get_option( 'comments_notify' );
+    $maybe_notify = $is_note ? get_option( 'wp_notes_notify', 1 ) : get_option( 'comments_notify' );
 
     /**
@@ -2457 +2457 @@
 
     return wp_notify_postauthor( $comment_id );
+}
+
+/**
+ * Send a notification to the post author when a new note is added via the REST API.
+ *
+ * @since 6.9.0
+ *
+ * @param WP_Comment $comment The comment object.
+ */
+function wp_new_comment_via_rest_notify_postauthor( $comment ) {
+    if ( $comment instanceof WP_Comment && 'note' === $comment->comment_type ) {
+        wp_new_comment_notify_postauthor( (int) $comment->comment_ID );
+    }
 }
 

trunk/src/wp-includes/default-filters.php

@@ -523 +523 @@
 add_action( 'comment_post', 'wp_new_comment_notify_moderator' );
 add_action( 'comment_post', 'wp_new_comment_notify_postauthor' );
-add_action( 'rest_insert_comment', array( 'WP_REST_Comments_Controller', 'wp_new_comment_via_rest_notify_postauthor' ) );
+add_action( 'rest_insert_comment', 'wp_new_comment_via_rest_notify_postauthor' );
 add_action( 'after_password_reset', 'wp_password_change_notification' );
 add_action( 'register_new_user', 'wp_send_new_user_notifications' );

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -37 +37 @@
     }
 
-    /**
-     * Send a notification to the post author when a new note is added via the REST API.
-     *
-     * @since 6.9.0
-     *
-     * @param WP_Comment $comment The comment object.
-     */
-    public static function wp_new_comment_via_rest_notify_postauthor( $comment ) {
-        if ( 'note' === $comment->comment_type ) {
-            wp_new_comment_notify_postauthor( $comment->comment_ID );
-        }
-    }
     /**
      * Registers the routes for comments.