Changeset 61198

Timestamp:

11/10/2025 10:29:26 PM (5 weeks ago)

Author:

joedolson

Message:

Themes: Improve type checking in wp_title.

Follow up to [61108].

Change type handling to ensure that falsey string values like 0 are correctly handled. Improves readability of underlying code by consolidating type checks and passing resulting array to the wp_title_parts filter.

Props tobiasbg, sabernhardt, sirlouen, wildworks, joedolson, mukesh27.
Fixes #61352.

File:

• trunk/src/wp-includes/general-template.php (modified) (2 diffs)

trunk/src/wp-includes/general-template.php

@@ -1425 +1425 @@
     }
 
-    $prefix = '';
-    if ( ! empty( $title ) ) {
-        $prefix = " $sep ";
+    if ( ! is_string( $title ) ) {
+        $title = '';
+    }
+
+    $prefix      = '';
+    $title_array = array();
+    if ( '' !== $title ) {
+        $prefix      = " $sep ";
+        $title_array = explode( $t_sep, $title );
     }
 
@@ -1437 +1443 @@
      * @param string[] $title_array Array of parts of the page title.
      */
-    $title_array = apply_filters( 'wp_title_parts', ! empty( $title ) ? explode( $t_sep, $title ) : array() );
+    $title_array = apply_filters( 'wp_title_parts', $title_array );
 
     // Determines position of the separator and direction of the breadcrumb.