Changeset 61061

Timestamp:

10/25/2025 06:22:07 PM (7 weeks ago)

Author:

westonruter

Message:

Formatting: Replace non-breaking hyphens (U+2011) with hyphens in sanitize_title_with_dashes().

Developed in ​https://github.com/WordPress/wordpress-develop/pull/10204

Follow-up to [18705], [36775].

Props patpiwo, westonruter, dmsnell.
See #31790, #10797.
Fixes #64089.

Location:

trunk

Files:

• src/wp-includes/formatting.php (modified) (1 diff)
• tests/phpunit/tests/formatting/sanitizeTitleWithDashes.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -2295 +2295 @@
 
     if ( 'save' === $context ) {
-        // Convert &nbsp, &ndash, and &mdash to hyphens.
-        $title = str_replace( array( '%c2%a0', '%e2%80%93', '%e2%80%94' ), '-', $title );
-        // Convert &nbsp, &ndash, and &mdash HTML entities to hyphens.
-        $title = str_replace( array( ' ', ' ', '–', '–', '—', '—' ), '-', $title );
+        // Convert &nbsp, non-breaking hyphen, &ndash, and &mdash to hyphens.
+        $title = str_replace( array( '%c2%a0', '%e2%80%91', '%e2%80%93', '%e2%80%94' ), '-', $title );
+        // Convert &nbsp, non-breaking hyphen, &ndash, and &mdash HTML entities to hyphens.
+        $title = str_replace( array( ' ', '‑', ' ', '–', '–', '—', '—' ), '-', $title );
         // Convert forward slash to hyphen.
         $title = str_replace( '/', '-', $title );

trunk/tests/phpunit/tests/formatting/sanitizeTitleWithDashes.php

@@ -84 +84 @@
         $this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do – the – Dash', '', 'save' ) );
         $this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do — the — Dash', '', 'save' ) );
+    }
+
+    /**
+     * @ticket 64089
+     */
+    public function test_replaces_non_breaking_hyphen() {
+        $this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do‑the Dash', '', 'save' ) );
+    }
+
+    /**
+     * @ticket 64089
+     */
+    public function test_replaces_non_breaking_hyphen_entity() {
+        $this->assertSame( 'do-the-dash', sanitize_title_with_dashes( 'Do ‑ the Dash', '', 'save' ) );
     }