Changeset 60678

Timestamp:

08/26/2025 11:19:47 PM (6 months ago)

Author:

TimothyBlynJacobs

Message:

Media: Fix playlist shortcodes not rendering correctly if the first playlist is broken.

The playlist shortcode has a base set of JavaScript that should only be loaded once. Previously, this JS was only loaded the first time a playlist shortcode was processed. If the first playlist was broken, because the media file was missing for instance, this would break all other playlists on the page.

This commit introduces a new static variable to keep track of whether the necessary JavaScript has been loaded instead.

Props iamadisingh, abcd95, justlevine, jorbin, rollybueno, Guido07111975.
Fixes #63583.

Location:

trunk

Files:

• src/wp-includes/media.php (modified) (3 diffs)
• tests/phpunit/tests/media/wpPlaylistShortcode.php (added)

trunk/src/wp-includes/media.php

@@ -3057 +3057 @@
     ++$instance;
 
+    static $is_loaded = false;
+
     if ( ! empty( $attr['ids'] ) ) {
         // 'ids' is explicitly ordered, unless you specify otherwise.
@@ -3238 +3240 @@
     ob_start();
 
-    if ( 1 === $instance ) {
+    if ( ! $is_loaded ) {
         /**
          * Prints and enqueues playlist scripts, styles, and JavaScript templates.
@@ -3248 +3250 @@
          */
         do_action( 'wp_playlist_scripts', $atts['type'], $atts['style'] );
+        $is_loaded = true;
     }
     ?>