Rebase GDBJIT interface solely on JITCodeEvent

Rebase GDBJIT interface solely on JITCodeEvent

[email protected]
BUG=

Committed: https://chromium.googlesource.com/v8/v8/+/8989d828e86bc7edae5e25687bcb60c0e301dffb

[wingo, 2015-02-25 09:56:33]

PTAL.  I tried it out and the backtraces and frame info I get in GDB are the
same, as far as I can tell.

[Michael Starzinger, 2015-02-25 10:16:46]

LGTM. I love it! Just nits.

https://codereview.chromium.org/957673004/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/957673004/diff/1/src/flag-definitions.h#newco...
src/flag-definitions.h:792: #define FLAG FLAG_FULL
nit: Can we move the mark-compact.cc flags up a few lines (i.e. to around line
755)? Then redefining the FLAG to FLAG_FULL here wouldn't be necessary. WDYT?

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc
File src/gdb-jit.cc (right):

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc#newcode1938
src/gdb-jit.cc:1938: struct SplayTreeConfig {
Splay tree is best tree. :)

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc#newcode2170
src/gdb-jit.cc:2170: }  // namespace v8::internal::GDBJITInterface
nit: Likewise.

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.h
File src/gdb-jit.h (right):

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.h#newcode38
src/gdb-jit.h:38: }  // namespace v8::internal
nit: Better use the following style, then clang-format is less confused:

}  // namespace internal
}  // namespace v8

[wingo, 2015-02-25 11:49:11]

Nits addressed, thanks for the review :)

https://codereview.chromium.org/957673004/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/957673004/diff/1/src/flag-definitions.h#newco...
src/flag-definitions.h:792: #define FLAG FLAG_FULL
On 2015/02/25 10:16:45, Michael Starzinger wrote:
> nit: Can we move the mark-compact.cc flags up a few lines (i.e. to around line
> 755)? Then redefining the FLAG to FLAG_FULL here wouldn't be necessary. WDYT?

Done.

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc
File src/gdb-jit.cc (right):

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc#newcode1938
src/gdb-jit.cc:1938: struct SplayTreeConfig {
On 2015/02/25 10:16:45, Michael Starzinger wrote:
> Splay tree is best tree. :)

Ack :-)

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc#newcode2170
src/gdb-jit.cc:2170: }  // namespace v8::internal::GDBJITInterface
On 2015/02/25 10:16:45, Michael Starzinger wrote:
> nit: Likewise.

Done.

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.h
File src/gdb-jit.h (right):

https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.h#newcode38
src/gdb-jit.h:38: }  // namespace v8::internal
On 2015/02/25 10:16:45, Michael Starzinger wrote:
> nit: Better use the following style, then clang-format is less confused:
> 
> }  // namespace internal
> }  // namespace v8

Done.

[commit-bot: I haz the power, 2015-02-25 11:49:58]

Patchset 2 (id:??) landed as
https://crrev.com/8989d828e86bc7edae5e25687bcb60c0e301dffb
Cr-Commit-Position: refs/heads/master@{#26847}

[wingo, 2015-02-25 11:50:01]

Committed patchset #2 (id:20001) manually as
8989d828e86bc7edae5e25687bcb60c0e301dffb (presubmit successful).

[Benedikt Meurer, 2015-02-25 12:02:35]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/954833004/ by [email protected].

The reason for reverting is: Doesn't compile.

[Yang, 2015-02-25 12:16:57]

On 2015/02/25 12:02:35, Benedikt Meurer wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/954833004/ by mailto:[email protected].
> 
> The reason for reverting is: Doesn't compile.

Please use the commit queue in the future to land CLs.

[wingo, 2015-02-25 12:35:04]

On 2015/02/25 12:16:57, Yang wrote:
> On 2015/02/25 12:02:35, Benedikt Meurer wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/954833004/ by mailto:[email protected].
> > 
> > The reason for reverting is: Doesn't compile.
> 
> Please use the commit queue in the future to land CLs.

My apologies for being an idiot.  Will use the CQ in the future, thanks.