Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2735103003: Merged: [wasm] Fix code specialization for empty memory buffer (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

Merged: [wasm] Fix code specialization for empty memory buffer Revision: 7d8a3028ddabbf3db5e3f5fb23d0fb1dadcc21ab BUG=chromium:698587 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Review-Url: https://codereview.chromium.org/2735103003 . Cr-Commit-Position: refs/branch-heads/5.8@{#13} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/c0b599d9ce16da8cad33c90dfdb5a687eb7ac786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -114 lines) Patch
M src/assembler.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M src/wasm/wasm-code-specialization.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-wasm-machops.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-arm.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-arm64.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-ia32.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-x64.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-x87.cc View 2 chunks +8 lines, -15 lines 0 comments Download
A test/mjsunit/regress/wasm/regression-698587.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Clemens Hammacher
3 years, 9 months ago (2017-03-07 15:01:39 UTC) #1
titzer
On 2017/03/07 15:01:39, Clemens Hammacher wrote: lgtm (rubber-stamped)
3 years, 9 months ago (2017-03-07 15:04:52 UTC) #2
Clemens Hammacher
3 years, 9 months ago (2017-03-07 15:05:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0b599d9ce16da8cad33c90dfdb5a687eb7ac786.

Powered by Google App Engine
This is Rietveld 408576698