Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2728763005: Merged: s390: Fix logic to check for overflow (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

Merged: s390: Fix logic to check for overflow Revision: ef2a9e2debc8b8888348a4231d155e7ddcc86bda NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected], [email protected], [email protected] BUG= Review-Url: https://codereview.chromium.org/2728763005 Cr-Commit-Position: refs/branch-heads/5.8@{#11} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/bb90d7e580dc308229ba38b27d3830926ccad50c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M src/s390/simulator-s390.cc View 2 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
JaideepBajwa
3 years, 9 months ago (2017-03-02 20:30:17 UTC) #1
JaideepBajwa
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 9 months ago (2017-03-02 20:30:19 UTC) #2
JaideepBajwa
ptal
3 years, 9 months ago (2017-03-02 20:30:35 UTC) #3
john.yan
lgtm
3 years, 9 months ago (2017-03-02 20:36:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728763005/1
3 years, 9 months ago (2017-03-02 20:37:06 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 20:37:23 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698