Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2641153002: Merged: Revert of [Ignition/turbo] Add a CallWithSpread bytecode. (Closed)

Created:
3 years, 11 months ago by petermarshall
Modified:
3 years, 11 months ago
Reviewers:
Michael Hablich
CC:
v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: Revert of [Ignition/turbo] Add a CallWithSpread bytecode. Merge of 75b861210f20ae00972125d21eed1ac234ba2825 Reason for revert: Causes a few bugs caught by clusterfuzz. Original issue's description: > [Ignition/turbo] Add a CallWithSpread bytecode. > > Also, emit a NewWithSpread bytecode for CallNew AST nodes where possible, rather than desugaring in the parser. > > BUG=v8:5511 > > Review-Url: https://codereview.chromium.org/2629363002 > Cr-Commit-Position: refs/heads/master@{#42455} > Committed: https://chromium.googlesource.com/v8/v8/+/4bae43471d5685e34d8bd74458889b83e60235a0 [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5511 Review-Url: https://codereview.chromium.org/2642843002 Cr-Original-Commit-Position: refs/heads/master@{#42470} Review-Url: https://codereview.chromium.org/2641153002 Cr-Commit-Position: refs/branch-heads/5.7@{#7} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/2c1b5efe74c74d2d8a31ace078399ef41c0f0786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -70 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +21 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
petermarshall
PTAL (title + description probably needs work)
3 years, 11 months ago (2017-01-19 14:35:44 UTC) #2
Michael Hablich
On 2017/01/19 14:35:44, petermarshall wrote: > PTAL (title + description probably needs work) lgtm
3 years, 11 months ago (2017-01-19 14:38:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2641153002/1
3 years, 11 months ago (2017-01-19 14:38:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/2c1b5efe74c74d2d8a31ace078399ef41c0f0786
3 years, 11 months ago (2017-01-19 14:39:37 UTC) #11
Michael Hablich
3 years, 11 months ago (2017-01-19 14:46:33 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2647673002/ by [email protected].

The reason for reverting is: does not build.

Powered by Google App Engine
This is Rietveld 408576698