Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2284493002: Merged: Squashed multiple commits. (Closed)

Created:
4 years, 3 months ago by john.yan
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: Fix FastAccessorToSmi CCTest to use ptr type Revision: abd32fb1c7c8ca6344abcf334b9459956c106565 Merged: Implement Big-Endian eqv test for DecodeDate and DecodeValueObjects Revision: 54f5558d52e09ba8729ca395ada270603116eeb1 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected], [email protected], [email protected], [email protected] BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M test/cctest/test-api-fast-accessor-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/value-serializer-unittest.cc View 4 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
john.yan
4 years, 3 months ago (2016-08-25 20:57:52 UTC) #1
john.yan
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 3 months ago (2016-08-25 20:57:54 UTC) #2
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-08-26 09:26:43 UTC) #3
Michael Hablich
On 2016/08/26 09:26:43, Jakob wrote: > lgtm Just tests, lgtm
4 years, 3 months ago (2016-08-26 10:42:27 UTC) #4
vogelheim
lgtm
4 years, 3 months ago (2016-08-26 10:54:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284493002/1
4 years, 3 months ago (2016-08-26 13:02:03 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 13:02:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698