Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1877223005: Version 5.1.281.6 (cherry-pick) (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/[email protected]
Target Ref:
refs/pending/branch-heads/5.1
Project:
v8
Visibility:
Public.

Description

Version 5.1.281.6 (cherry-pick) Merged 03975befe31fbc357928fbdc8cf8cf49533eada1 [turbofan] Remove some clever-but-wrong bits from select lowering. BUG=chromium:600593 LOG=N [email protected] Committed: https://chromium.googlesource.com/v8/v8/+/8e4f1e953ba1051fa5442dee86381b30f6aab853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -134 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/select-lowering.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/select-lowering.cc View 2 chunks +4 lines, -49 lines 0 comments Download
A test/mjsunit/compiler/regress-600593.js View 1 chunk +21 lines, -0 lines 0 comments Download
D test/unittests/compiler/select-lowering-unittest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
4 years, 8 months ago (2016-04-13 07:30:14 UTC) #1
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-13 07:33:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877223005/1
4 years, 8 months ago (2016-04-13 07:33:41 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-13 07:33:44 UTC) #6
Jarin
4 years, 8 months ago (2016-04-13 08:18:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e4f1e953ba1051fa5442dee86381b30f6aab853.

Powered by Google App Engine
This is Rietveld 408576698