Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1645573002:
[regexp] restrict pattern syntax for unicode mode. (Closed)
|
Created:
4 years, 11 months ago by Yang Modified:
4 years, 10 months ago Reviewers:
vogelheim CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@stage Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[regexp] restrict pattern syntax for unicode mode.
ES2015 Annex B.1.4 specifies a restricted pattern language for unicode
mode. This change reflects that, based on some test262 test cases.
[email protected]
BUG=v8:2952
LOG=N
Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223
Cr-Commit-Position: refs/heads/master@{#33584}
Committed: https://crrev.com/bb6a53573cd05786c0a6e4a229d57f63582161c8
Cr-Commit-Position: refs/heads/master@{#33603}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : commments and error messages #Patch Set 4 : allow forward slash as identity escape #
Total comments: 4
Patch Set 5 : rebase #Patch Set 6 : addressed comments #
Messages
Total messages: 34 (16 generated)
The CQ bit was checked by [email protected] to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645573002/1
The CQ bit was unchecked by [email protected]
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
The CQ bit was checked by [email protected] to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645573002/20001
The CQ bit was unchecked by [email protected]
Dry run: This issue passed the CQ dry run.
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by [email protected] to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645573002/60001
[email protected] changed reviewers: + [email protected] - [email protected]
Daniel, could you take a look at this?
The CQ bit was checked by [email protected] to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645573002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645573002/80001
The CQ bit was unchecked by [email protected]
Dry run: This issue passed the CQ dry run.
lgtm Two nitpicks about the error handling; but honestly I'm not sure I even understand that. https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse... File src/regexp/regexp-parser.cc (right): https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse... src/regexp/regexp-parser.cc:496: ReportError(CStrVector("Lone quantifier brackets") CHECK_FAILED); I don't get the point of the ReportError(... CHECK_FAILED) construct. As I read it, ReportError set failed_ = true; and returns NULL, and CHECK_FAILED will test for failed_ and return NULL, too. Wouldn't return ReportError(...) do the same thing, except somewhat less unorthodox? https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse... src/regexp/regexp-parser.cc:1029: return ReportError(CStrVector(kRangeInvalid) CHECK_FAILED); CHECK_FAILED adds a return, after the unconditional return in this line.
The CQ bit was checked by [email protected]
The patchset sent to the CQ was uploaded after l-g-t-m from [email protected] Link to the patchset: https://codereview.chromium.org/1645573002/#ps120001 (title: "addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645573002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645573002/120001
https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse... File src/regexp/regexp-parser.cc (right): https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse... src/regexp/regexp-parser.cc:496: ReportError(CStrVector("Lone quantifier brackets") CHECK_FAILED); On 2016/01/28 13:38:21, vogelheim wrote: > I don't get the point of the ReportError(... CHECK_FAILED) construct. > > As I read it, ReportError set failed_ = true; and returns NULL, and CHECK_FAILED > will test for failed_ and return NULL, too. Wouldn't return ReportError(...) do > the same thing, except somewhat less unorthodox? Done. https://codereview.chromium.org/1645573002/diff/80001/src/regexp/regexp-parse... src/regexp/regexp-parser.cc:1029: return ReportError(CStrVector(kRangeInvalid) CHECK_FAILED); On 2016/01/28 13:38:21, vogelheim wrote: > CHECK_FAILED adds a return, after the unconditional return in this line. You are completely right. I simply copied the code from other places where we call ReportError. Fixed all of those places now.
Message was sent while issue was closed.
Committed patchset #6 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [regexp] restrict pattern syntax for unicode mode. ES2015 Annex B.1.4 specifies a restricted pattern language for unicode mode. This change reflects that, based on some test262 test cases. [email protected] BUG=v8:2952 LOG=N ========== to ========== [regexp] restrict pattern syntax for unicode mode. ES2015 Annex B.1.4 specifies a restricted pattern language for unicode mode. This change reflects that, based on some test262 test cases. [email protected] BUG=v8:2952 LOG=N Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 Cr-Commit-Position: refs/heads/master@{#33584} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 Cr-Commit-Position: refs/heads/master@{#33584}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:120001) has been created in https://codereview.chromium.org/1648673002/ by [email protected]. The reason for reverting is: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....
Message was sent while issue was closed.
Description was changed from ========== [regexp] restrict pattern syntax for unicode mode. ES2015 Annex B.1.4 specifies a restricted pattern language for unicode mode. This change reflects that, based on some test262 test cases. [email protected] BUG=v8:2952 LOG=N Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 Cr-Commit-Position: refs/heads/master@{#33584} ========== to ========== [regexp] restrict pattern syntax for unicode mode. ES2015 Annex B.1.4 specifies a restricted pattern language for unicode mode. This change reflects that, based on some test262 test cases. [email protected] BUG=v8:2952 LOG=N Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 Cr-Commit-Position: refs/heads/master@{#33584} ==========
The CQ bit was checked by [email protected]
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645573002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645573002/120001
Message was sent while issue was closed.
Description was changed from ========== [regexp] restrict pattern syntax for unicode mode. ES2015 Annex B.1.4 specifies a restricted pattern language for unicode mode. This change reflects that, based on some test262 test cases. [email protected] BUG=v8:2952 LOG=N Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 Cr-Commit-Position: refs/heads/master@{#33584} ========== to ========== [regexp] restrict pattern syntax for unicode mode. ES2015 Annex B.1.4 specifies a restricted pattern language for unicode mode. This change reflects that, based on some test262 test cases. [email protected] BUG=v8:2952 LOG=N Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 Cr-Commit-Position: refs/heads/master@{#33584} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [regexp] restrict pattern syntax for unicode mode. ES2015 Annex B.1.4 specifies a restricted pattern language for unicode mode. This change reflects that, based on some test262 test cases. [email protected] BUG=v8:2952 LOG=N Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 Cr-Commit-Position: refs/heads/master@{#33584} ========== to ========== [regexp] restrict pattern syntax for unicode mode. ES2015 Annex B.1.4 specifies a restricted pattern language for unicode mode. This change reflects that, based on some test262 test cases. [email protected] BUG=v8:2952 LOG=N Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 Cr-Commit-Position: refs/heads/master@{#33584} Committed: https://crrev.com/bb6a53573cd05786c0a6e4a229d57f63582161c8 Cr-Commit-Position: refs/heads/master@{#33603} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/bb6a53573cd05786c0a6e4a229d57f63582161c8 Cr-Commit-Position: refs/heads/master@{#33603} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
