Issue 1070653003: When sweeping is in progress, either finalize or do nothing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1070653003: When sweeping is in progress, either finalize or do nothing (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 8 months ago

Reviewers:
Hannes Payer (out of office), rmcilroy

CC:
Paweł Hajdan Jr., v8-dev

Base URL:
https://chromium.googlesource.com/v8/[email protected]

Target Ref:
refs/pending/branch-heads/4.3

Project:
v8

Visibility:
Public.

More Reviews

Description

When sweeping is in progress, either finalize or do nothing BUG=none LOG=n [email protected], [email protected] Committed: https://chromium.googlesource.com/v8/v8/+/102b18acddf7ffaa962995dd961eee1230f67b3f

Patch Set 2 : updates #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	include/v8-version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/heap/gc-idle-time-handler.cc	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

https://codereview.chromium.org/1070653003/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1070653003/diff/1/src/heap/gc-idle-time-handler.cc#newcode260 src/heap/gc-idle-time-handler.cc:260: return GCIdleTimeAction::Nothing(); return NothingOrDone() here instead.

5 years, 8 months ago (2015-04-08 12:04:21 UTC) #2

jochen (gone - plz use gerrit)

5 years, 8 months ago (2015-04-08 12:29:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
102b18acddf7ffaa962995dd961eee1230f67b3f (presubmit successful).

Expand Messages | Collapse Messages

Issue 1070653003: When sweeping is in progress, either finalize or do nothing (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages