Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1070653003: When sweeping is in progress, either finalize or do nothing (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/[email protected]
Target Ref:
refs/pending/branch-heads/4.3
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-08 10:00:55 UTC) #1
rmcilroy
https://codereview.chromium.org/1070653003/diff/1/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/1070653003/diff/1/src/heap/gc-idle-time-handler.cc#newcode260 src/heap/gc-idle-time-handler.cc:260: return GCIdleTimeAction::Nothing(); return NothingOrDone() here instead.
5 years, 8 months ago (2015-04-08 12:04:21 UTC) #2
jochen (gone - plz use gerrit)
ptal
5 years, 8 months ago (2015-04-08 12:05:54 UTC) #3
rmcilroy
lgtm, thanks!
5 years, 8 months ago (2015-04-08 12:27:30 UTC) #4
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-08 12:29:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
102b18acddf7ffaa962995dd961eee1230f67b3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698