Add process.Child.Cwd, use it for cwd and remove cwd_dir field #31090

Merged

andrewrk merged 2 commits from squeek502/zig:unify-child-cwd into master 2026-02-02 19:56:43 +01:00

Conversation 2 Commits 2 Files changed 13 +120 -84

squeek502 commented 2026-02-02 10:49:45 +01:00

Member

Copy link

Builds on the changes in #30112 (this branch contains a rebased version of that PR) and extends it, intending to close https://github.com/ziglang/zig/issues/5190.

Instead of deprecating/removing the []const u8 version of providing the CWD of a child process, the CWD option is now a tagged union with the fields inherit (inherit the CWD of the parent process), dir (provide CWD as an Io.Dir), or path (provide CWD as a []const u8). The reasoning for this is laid out here: #30112 (comment). The simple version is:

• Windows must provide a path when specifying the CWD when spawning a process, so the path of an Io.Dir must be resolved before actually spawning
• A directory handle may have multiple paths associated with it, so providing the CWD as a string retains a legitimate use case in cases where the precise path matters

Builds on the changes in https://codeberg.org/ziglang/zig/pulls/30112 (this branch contains a rebased version of that PR) and extends it, intending to close https://github.com/ziglang/zig/issues/5190. Instead of deprecating/removing the `[]const u8` version of providing the CWD of a child process, the CWD option is now a tagged union with the fields `inherit` (inherit the CWD of the parent process), `dir` (provide CWD as an `Io.Dir`), or `path` (provide CWD as a `[]const u8`). The reasoning for this is laid out here: https://codeberg.org/ziglang/zig/pulls/30112#issuecomment-8711850. The simple version is: - Windows must provide a path when specifying the CWD when spawning a process, so the path of an `Io.Dir` must be resolved before actually spawning - A directory handle may have multiple paths associated with it, so providing the CWD as a string retains a legitimate use case in cases where the precise path matters

squeek502 added 2 commits 2026-02-02 10:49:46 +01:00

Windows: Support directory handle for cwd instead of string for Child.process ... 83abd73801

This implementation is a bit of a hacky workaround, as we use a ntdll
API to grab the full path of the directory handle. As far as I can tell
this might be the only solution to the problem, as
kernel32.CreateProcessW takes a directory path as a string only.

I might be wrong though as haven't researched the problem thoroughly.

Add process.Child.Cwd, use it for cwd and remove cwd_dir field ... 05346e123b

The user must now explicitly choose between inheriting the current CWD, passing a path for the CWD, or passing a Dir for the CWD.

andrewrk approved these changes 2026-02-02 19:56:25 +01:00

andrewrk left a comment

Copy link

Nice, thank you

Nice, thank you

andrewrk merged commit b71e593df4 into master 2026-02-02 19:56:43 +01:00

andrewrk referenced this pull request from a commit 2026-02-02 19:56:44 +01:00

Merge pull request 'Add process.Child.Cwd, use it for cwd and remove cwd_dir field' (#31090) from squeek502/zig:unify-child-cwd into master

Moosichu commented 2026-02-03 22:07:15 +01:00

First-time contributor

Copy link

Thank you for doing this! 🙏

Thank you for doing this! 🙏

❤️ 1

squeek502 referenced this pull request from a commit 2026-03-08 10:38:41 +01:00

Io: Add processSetCurrentPath

squeek502 referenced this pull request 2026-03-08 10:39:38 +01:00

Io: Add processSetCurrentPath #31420

andrewrk referenced this pull request from a commit 2026-03-09 03:19:16 +01:00

Io: Add processSetCurrentPath

GasInfinity referenced this pull request from a commit 2026-03-09 12:46:14 +01:00

Io: Add processSetCurrentPath

gero3 referenced this pull request from a commit 2026-03-09 17:50:44 +01:00

Io: Add processSetCurrentPath

invlpg referenced this pull request from a commit 2026-03-21 12:50:33 +01:00

Io: Add processSetCurrentPath

ARandomOSDever referenced this pull request from a commit 2026-06-06 11:45:17 +02:00

Io: Add processSetCurrentPath

Sign in to join this conversation.

Reviewers

No reviewers

andrewrk

Labels

Clear labels   

abi/f32

  

abi/ilp32

  

abi/sf

  

accepted

This proposal is planned.

  

arch/21k

  

arch/6502

  

arch/aarch64

  

arch/alpha

  

arch/amdgcn

  

arch/arc

  

arch/arc32

  

arch/arc64

  

arch/arm

  

arch/avr

  

arch/bfin

  

arch/bpf

  

arch/colossus

  

arch/cris

  

arch/csky

  

arch/dlx

  

arch/epiphany

  

arch/fr30

  

arch/frv

  

arch/hexagon

  

arch/hppa

  

arch/hppa64

  

arch/ia64

  

arch/kalimba

  

arch/kvx

  

arch/lanai

  

arch/lm32

  

arch/loongarch32

  

arch/loongarch64

  

arch/m32r

  

arch/m68k

  

arch/m88k

  

arch/mcore

  

arch/microblaze

  

arch/mips

  

arch/mips64

  

arch/mmix

  

arch/moxie

  

arch/mrisc32

  

arch/msp430

  

arch/nds32

  

arch/ns32k

  

arch/nvptx

  

arch/or1k

  

arch/powerpc

  

arch/powerpc64

  

arch/propeller

  

arch/riscv32

  

arch/riscv64

  

arch/rl78

  

arch/rx

  

arch/s390x

  

arch/sh

  

arch/sparc

  

arch/sparc64

  

arch/spirv

  

arch/spu

  

arch/tricore

  

arch/v850

  

arch/vax

  

arch/vc4

  

arch/ve

  

arch/wasm

  

arch/x86

  

arch/x86_64

  

arch/xcore

  

arch/xtensa

  

autodoc

The web application for interactive documentation and generation of its assets.

  

backend/c

The C backend outputs C source code.

  

backend/llvm

The LLVM backend outputs an LLVM bitcode module.

  

backend/self-hosted

The self-hosted backends produce machine code directly.

  

binutils

Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.

  

breaking

Implementing this issue could cause existing code to no longer compile or have different behavior.

  

build system

The Zig build system - zig build, std.Build, the build runner, and package management.

  

debug info

An issue related to debug information (e.g. DWARF) produced by the Zig compiler.

  

docs

An issue with documentation, e.g. the language reference or standard library doc comments.

  

error message

This issue points out an error message that is unhelpful and should be improved.

  

frontend

Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.

  

fuzzing

An issue related to Zig's integrated fuzz testing.

  

incremental

Reuse of internal compiler state for faster compilation.

  

lib/c

This issue relates to Zig's libc implementation and/or vendored libcs.

  

lib/compiler-rt

This issue relates to Zig's compiler-rt library.

  

lib/cxx

This issue relates to Zig's vendored libc++ and/or libc++abi.

  

lib/std

This issue relates to Zig's standard library.

  

lib/tsan

This issue relates to Zig's vendored libtsan.

  

lib/ubsan-rt

This issue relates to Zig's ubsan-rt library.

  

lib/unwind

This issue relates to Zig's vendored libunwind.

  

linking

Zig's integrated object file and incremental linker.

  

miscompilation

The compiler reports success but produces semantically incorrect code.

  

os/android

  

os/contiki

  

os/dragonfly

  

os/driverkit

  

os/emscripten

  

os/freebsd

  

os/fuchsia

  

os/haiku

  

os/hermit

  

os/hurd

  

os/illumos

  

os/ios

  

os/linux

  

os/maccatalyst

  

os/macos

  

os/managarm

  

os/netbsd

  

os/ohos

  

os/openbsd

  

os/plan9

  

os/redox

  

os/rtems

  

os/serenity

  

os/tvos

  

os/uefi

  

os/visionos

  

os/wasi

  

os/watchos

  

os/windows

  

proposal

This issue suggests language modifications. If it also has the "accepted" label then it is planned.

  

release notes

This issue or pull request should be mentioned in the release notes.

  

testing

This issue is related to testing the compiler, standard library, or other parts of Zig.

  

zig cc

Zig as a drop-in C-family compiler.

  

zig fmt

The Zig source code formatter.

  

zig reduce

The Zig source code reduction tool.

  

bounty

https://ziglang.org/news/announcing-donor-bounties

  

bug

Observed behavior contradicts documented or intended behavior.

  

contributor-friendly

This issue is limited in scope and/or knowledge of project internals.

  

downstream

An issue with a third-party project that uses this project.

  

enhancement

Solving this issue will likely involve adding new logic or components to the codebase.

  

infra

An issue related to project infrastructure, e.g. continuous integration.

  

optimization

A task to improve performance and/or resource usage.

  

question

No questions on the issue tracker; use a community space instead.

  

regression

Something that used to work in a previous version stopped working

  

upstream

An issue with a third-party project that this project uses.

No labels

abi/f32

abi/ilp32

abi/sf

accepted

arch/21k

arch/6502

arch/aarch64

arch/alpha

arch/amdgcn

arch/arc

arch/arc32

arch/arc64

arch/arm

arch/avr

arch/bfin

arch/bpf

arch/colossus

arch/cris

arch/csky

arch/dlx

arch/epiphany

arch/fr30

arch/frv

arch/hexagon

arch/hppa

arch/hppa64

arch/ia64

arch/kalimba

arch/kvx

arch/lanai

arch/lm32

arch/loongarch32

arch/loongarch64

arch/m32r

arch/m68k

arch/m88k

arch/mcore

arch/microblaze

arch/mips

arch/mips64

arch/mmix

arch/moxie

arch/mrisc32

arch/msp430

arch/nds32

arch/ns32k

arch/nvptx

arch/or1k

arch/powerpc

arch/powerpc64

arch/propeller

arch/riscv32

arch/riscv64

arch/rl78

arch/rx

arch/s390x

arch/sh

arch/sparc

arch/sparc64

arch/spirv

arch/spu

arch/tricore

arch/v850

arch/vax

arch/vc4

arch/ve

arch/wasm

arch/x86

arch/x86_64

arch/xcore

arch/xtensa

autodoc

backend/c

backend/llvm

backend/self-hosted

binutils

breaking

build system

debug info

docs

error message

frontend

fuzzing

incremental

lib/c

lib/compiler-rt

lib/cxx

lib/std

lib/tsan

lib/ubsan-rt

lib/unwind

linking

miscompilation

os/android

os/contiki

os/dragonfly

os/driverkit

os/emscripten

os/freebsd

os/fuchsia

os/haiku

os/hermit

os/hurd

os/illumos

os/ios

os/linux

os/maccatalyst

os/macos

os/managarm

os/netbsd

os/ohos

os/openbsd

os/plan9

os/redox

os/rtems

os/serenity

os/tvos

os/uefi

os/visionos

os/wasi

os/watchos

os/windows

proposal

release notes

testing

zig cc

zig fmt

zig reduce

bounty

bug

contributor-friendly

downstream

enhancement

infra

optimization

question

regression

upstream

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ziglang/zig!31090

No description provided.