dgkf/options
2
4
Fork 0
Code Issues Pull requests 1 Releases 5 Packages Activity Actions

Fix: null defaults, logical envvar parsing #34

Merged
dgkf merged 3 commits from 33-null-defaults into main 2025-03-28 22:02:13 +01:00
Conversation 0 Commits 3 Files changed 7 +35 -10
dgkf commented 2025-03-28 17:29:55 +01:00
Owner
Copy link

Closes #33
Closes #32

  • Fixed define_options when using a NULL default value. Previously,
    the NULL value would not be recognized and would silently ignore the
    option definition. (@dgkf #34)

  • Fixed envvar_is.logical (and thereby, envvar_is_true, envvar_is_false),
    leveraging as.logical internally to make the parsing from strings align
    more closely to what one may expect in R. Notably, all lowercase values
    true and false will now be recognized as their respective logical values.
    (@dgkf #34)

Closes #33 Closes #32 * Fixed `define_options` when using a `NULL` default value. Previously, the `NULL` value would not be recognized and would silently ignore the option definition. (@dgkf #34) * Fixed `envvar_is.logical` (and thereby, `envvar_is_true`, `envvar_is_false`), leveraging `as.logical` internally to make the parsing from strings align more closely to what one may expect in R. Notably, all lowercase values `true` and `false` will now be recognized as their respective logical values. (@dgkf #34)
test ci
All checks were successful
ci/woodpecker/pr/r-pkg-standard Pipeline was successful
Details
8fc0fbf6fb
dgkf merged commit 3de5a6e8dc into main 2025-03-28 22:02:13 +01:00
dgkf deleted branch 33-null-defaults 2025-03-28 22:02:14 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
release

   
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
release
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dgkf/options!34
No description provided.