WIP: fix: use token to clone actions from local instance #855
No reviewers
Labels
No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
forgejo/runner!855
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "hailey/runner:local-instance-clone-token"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR supersedes #816 with @earl-warren's kind support. It depends on https://codeberg.org/forgejo/forgejo/pulls/8889 upstream
cascading-pr updated at actions/setup-forgejo#600
fcc055ae8478f63be201cascading-pr updated at actions/setup-forgejo#600
WIP: fix: use token to clone actions from local instanceto WIP: fix: use token to clone actions from local instance [skip cascade]I see what
[skip cascade]does now 😁 sorry about thatIt is fine really.
@hailey do you need anything? I mean beside time to work on that 😁
@hailey gentle ping. If you have no time to complete this, please say so 🙏
78f63be20100d12ac197WIP: fix: use token to clone actions from local instance [skip cascade]to fix: use token to clone actions from local instance [skip cascade]Hi! Sorry for the latency. I've rebased this branch against main, fixed that lint error, and tested that it works as expected in my own deployment against Forgejo v12.0.4+forgejo#8889.
It looks like all of the tests have passed except for one of the integration tests, which looks unrelated enough to this change that I think it's a flakey failure. I don't have access to re-run the build though. Other than that, I think we should be good to go here. Thanks again for your patience
00d12ac197f70de1ec5a@ -111,0 +114,4 @@if strings.HasPrefix(cloneURL, gitInstance+"/") {// only provide clone token if the action is on the same instance// which triggered the tasktoken = sar.RunContext.Config.GetToken()what happened if you run this runner version against forgejo < v13 ?
Good catch - it won't be able to access public repositories anymore due to the strict
task.RepoID == repo.IDcheck in Forgejo < 13. I don't think there's much we can do about this. Since these are pretty tightly coupled pieces of software anyway, maybe we just document that whichever version of the runner this lands in requires at least Forgejo 13does Forgejo send the version with the job payload? or something else we can use to distinguish support?
otherwise this will need to wait for at least next lts release of Forgejo
This can wait, I'm happy to keep running my branch deploy until then :)
fix: use token to clone actions from local instance [skip cascade]to fix: use token to clone actions from local instancefix: use token to clone actions from local instanceto WIP: fix: use token to clone actions from local instance@hailey it should be possible to implement this in a backward compatible way, don't you think?
This has been completed in a backwards-compatible method by #1249. Thanks for the work on this issue! I'll close it at this time.
Pull request closed