forgejo/runner
31
88
Fork 91
Code Issues 38 Pull requests 9 Releases 81 Packages 1 Activity Actions

chore: fix typos and add type checking to port/addr args #576

Merged
earl-warren merged 4 commits from :ipv6-fix into main 2025-06-01 15:03:23 +00:00
Conversation 6 Commits 4 Files changed 6 +23 -24
c8h4 commented 2025-05-24 11:07:00 +00:00
Member
Copy link

Hi!

ba2fc1273ce5cb04d96cfdbb47ebad929dcbd96f goes in tandem with forgejo/act#135 and adapts to the API changes for runner.Config.

I dropped the act interface changes according to forgejo/act#135 (comment), but kept the CLI changes here - as they are not breaking here.

Other three commits just fix up some typos around the tree - bit of a pet peeve of mine, sorry :^)

Hi! ~~ba2fc1273ce5cb04d96cfdbb47ebad929dcbd96f goes in tandem with https://code.forgejo.org/forgejo/act/pulls/135 and adapts to the API changes for `runner.Config.`~~ I dropped the act interface changes according to https://code.forgejo.org/forgejo/act/pulls/135#issuecomment-40695, but kept the CLI changes here - as they are not breaking here. Other three commits just fix up some typos around the tree - bit of a pet peeve of mine, sorry :^)
cascading-pr commented 2025-05-24 11:07:14 +00:00
Contributor
Copy link

cascading-pr updated at actions/setup-forgejo#385

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/385
earl-warren changed title from fix: cmd/exec: adapt to act runner config changes to fix: cmd/exec: adapt to act runner config changes [skip cascade] 2025-05-25 06:50:39 +00:00
earl-warren commented 2025-05-25 06:51:10 +00:00
Contributor
Copy link

Marking as [skip cascade] so that it does not trigger the full test suite until it is ready to succeed.

Marking as ` [skip cascade]` so that it does not trigger the full test suite until it is ready to succeed.
👍 1
c8h4 force-pushed ipv6-fix from ba2fc1273c
Some checks failed
checks / build and test (pull_request) Failing after 13s
Details
checks / runner exec tests (pull_request) Has been skipped
Details
/ example-docker-compose (pull_request) Successful in 1m20s
Details
/ cascade (pull_request_target) Failing after 3m11s
Details
to 65abd38f13
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / build and test (pull_request) Successful in 31s
Details
checks / runner exec tests (pull_request) Successful in 22s
Details
/ example-docker-compose (pull_request) Successful in 1m21s
Details
2025-05-25 12:45:56 +00:00 Compare
earl-warren changed title from fix: cmd/exec: adapt to act runner config changes [skip cascade] to fix: cmd/exec: adapt to act runner config changes 2025-05-26 04:58:42 +00:00
earl-warren changed title from fix: cmd/exec: adapt to act runner config changes to chore: fix typos and add type checking to port/addr args 2025-05-26 04:59:43 +00:00
earl-warren force-pushed ipv6-fix from 65abd38f13
All checks were successful
/ cascade (pull_request_target) Has been skipped
Details
checks / build and test (pull_request) Successful in 31s
Details
checks / runner exec tests (pull_request) Successful in 22s
Details
/ example-docker-compose (pull_request) Successful in 1m21s
Details
to 7dd8323f4c
All checks were successful
checks / build and test (pull_request) Successful in 53s
Details
/ example-docker-compose (pull_request) Successful in 1m22s
Details
checks / runner exec tests (pull_request) Successful in 26s
Details
/ cascade (pull_request_target) Successful in 42m23s
Details
2025-05-26 05:02:32 +00:00 Compare
cascading-pr commented 2025-05-26 05:02:44 +00:00
Contributor
Copy link

cascading-pr updated at actions/setup-forgejo#385

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/385
earl-warren approved these changes 2025-05-26 05:02:57 +00:00
Dismissed
earl-warren left a comment
Contributor
Copy link

I took the liberty of updating the PR title.

I took the liberty of updating the PR title.
👍 1
c8h4 force-pushed ipv6-fix from 7dd8323f4c
All checks were successful
checks / build and test (pull_request) Successful in 53s
Details
/ example-docker-compose (pull_request) Successful in 1m22s
Details
checks / runner exec tests (pull_request) Successful in 26s
Details
/ cascade (pull_request_target) Successful in 42m23s
Details
to d4766492c9
All checks were successful
checks / build and test (pull_request) Successful in 33s
Details
checks / runner exec tests (pull_request) Successful in 20s
Details
/ example-docker-compose (pull_request) Successful in 1m22s
Details
/ cascade (pull_request_target) Successful in 8s
Details
2025-06-01 09:59:47 +00:00 Compare
cascading-pr commented 2025-06-01 10:00:00 +00:00
Contributor
Copy link

cascading-pr updated at actions/setup-forgejo#392

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/392
earl-warren deleted branch ipv6-fix 2025-06-01 15:03:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
FreeBSD

   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Chore

It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le

powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/runner!576
No description provided.