refactor: clean-up error handling on task execution #1400

Merged

mfenniak merged 3 commits from mfenniak/forgejo-runner:refactor-task-errors into main 2026-02-23 15:21:56 +00:00

Conversation 1 Commits 3 Files changed 6 +37 -144

mfenniak commented 2026-02-23 00:57:39 +00:00

Owner

Copy link

The goal I had in mind was to make sure that once the runner has a task from FetchTask, it never has any error cases that don't get reported back to the server. I believe that's already practically the case, but I've applied a couple refactorings to clarify it:

• Run() no longer returns an error, to indicate that its expected to handle errors internally. Nearly no code paths used this.
• runningTasks (the only code path using the above) had a possibility for a race condition which could allow two instances of the same task to be run, which was fixed up.
• recover() is used when running jobs in a way that would not report status back to the server. But practically speaking these recover() blocks were never used because panics from within the job invocation are also recovered.

So, I think this just ends up as a refactor that removes some unused error handling, but it helps clarify that no error cases seem to exist that won't report status.

• other
  • PR: refactor: clean-up error handling on task execution

The goal I had in mind was to make sure that once the runner has a task from `FetchTask`, it never has any error cases that don't get reported back to the server. I believe that's already practically the case, but I've applied a couple refactorings to clarify it: - `Run()` no longer returns an error, to indicate that its expected to handle errors internally. Nearly no code paths used this. - `runningTasks` (the only code path using the above) had a possibility for a race condition which could allow two instances of the same task to be run, which was fixed up. - `recover()` is used when running jobs in a way that would not report status back to the server. But practically speaking these `recover()` blocks were never used because panics from within the job invocation [are also recovered](https://code.forgejo.org/forgejo/runner/src/commit/142689a39abeb50df8ea9f1b543ab8622b43a3b9/internal/app/run/runner.go#L231-L235). So, I think this just ends up as a refactor that removes some unused error handling, but it helps clarify that no error cases seem to exist that won't report status. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - other - [PR](https://code.forgejo.org/forgejo/runner/pulls/1400): <!--number 1400 --><!--line 0 --><!--description cmVmYWN0b3I6IGNsZWFuLXVwIGVycm9yIGhhbmRsaW5nIG9uIHRhc2sgZXhlY3V0aW9u-->refactor: clean-up error handling on task execution<!--description--> <!--end release-notes-assistant-->

mfenniak added 3 commits 2026-02-23 00:57:39 +00:00

refactor: do not allow error return from RunnerInterface.Run() 56bf91dfb4

fix: 'runningTasks' used unsafely for task concurrency prevention 8ba65cc3a3

refactor: remove unnecessary recover() clauses 883d47c9e6

mfenniak force-pushed refactor-task-errors from 883d47c9e6 to 071fe7c233 2026-02-23 01:17:14 +00:00 Compare

mfenniak force-pushed refactor-task-errors from 071fe7c233 to 3a5575be1f 2026-02-23 01:44:42 +00:00 Compare

aahlenst approved these changes 2026-02-23 14:01:01 +00:00

aahlenst left a comment

Member

Copy link

Very nice simplification.

Very nice simplification.

❤️ 1

mfenniak merged commit 9ff65b1a72 into main 2026-02-23 15:21:56 +00:00

mfenniak deleted branch refactor-task-errors 2026-02-23 15:21:57 +00:00

mfenniak referenced this pull request from a commit 2026-02-23 15:21:58 +00:00

refactor: clean-up error handling on task execution (#1400)

Sign in to join this conversation.

Reviewers

No reviewers

aahlenst

Labels

Clear labels   

FreeBSD

  

Kind/Breaking

Breaking change that won't be backward compatible

  

Kind/Bug

Something is not working

  

Kind/Chore

It is no fun but it needs to be done, this is a chore.

  

Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  

Kind/Documentation

Documentation changes

  

Kind/Enhancement

Improve existing functionality

  

Kind/Feature

New functionality

  

Kind/Security

This is security issue

  

Kind/Testing

Issue or pull request related to testing

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Reviewed

Confirmed

Issue has been confirmed

  

Reviewed

Duplicate

This issue or pull request already exists

  

Reviewed

Invalid

Invalid issue

  

Reviewed

Won't Fix

This issue won't be fixed

  

Status

Abandoned

Somebody has started to work on this but abandoned work

  

Status

Blocked

Something is blocking this issue or pull request

  

Status

Need More Info

Feedback is required to reproduce issue or to continue work

  

Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  

linux-powerpc64le

powerpc64le

  

linux-riscv64

  

linux-s390x

  

run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  

run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels

FreeBSD

Kind/Breaking

Kind/Bug

Kind/Chore

Kind/DependencyUpdate

Kind/Documentation

Kind/Enhancement

Kind/Feature

Kind/Security

Kind/Testing

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Reviewed

Confirmed

Reviewed

Duplicate

Reviewed

Invalid

Reviewed

Won't Fix

Status

Abandoned

Status

Blocked

Status

Need More Info

Windows

linux-powerpc64le

linux-riscv64

linux-s390x

run-end-to-end-tests

run-forgejo-tests

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

forgejo/runner!1400

No description provided.