feat: add connections to Runner configuration #1378

aahlenst · 2026-02-15T17:03:38Z

aahlenst commented

2026-02-15 17:03:38 +00:00

Introduce a new configuration element called server that can hold one or more connections. It enables connecting Forgejo Runner to multiple Forgejo instances (not implemented yet). It is planned that server.connections fully replaces the runnner file .runner.

See forgejo/forgejo-actions-feature-requests#88 for background and design considerations.

features
- PR: feat: add connections to Runner configuration

Introduce a new configuration element called `server` that can hold one or more `connections`. It enables connecting Forgejo Runner to multiple Forgejo instances (not implemented yet). It is planned that `server.connections` fully replaces the runnner file `.runner`. See https://code.forgejo.org/forgejo/forgejo-actions-feature-requests/issues/88 for background and design considerations.   - features - [PR](https://code.forgejo.org/forgejo/runner/pulls/1378): feat: add connections to Runner configuration

aahlenst added 2 commits

2026-02-15 17:03:39 +00:00

refactor: separate Config from on-disk format

checks / validate pre-commit-hooks file (pull_request) Successful in 37s

Details

checks / Build Forgejo Runner (pull_request) Successful in 43s

Details

checks / validate mocks (pull_request) Successful in 46s

Details

checks / Build unsupported platforms (pull_request) Successful in 20s

Details

checks / runner exec tests (pull_request) Successful in 34s

Details

checks / integration tests (docker-latest) (pull_request) Successful in 8m17s

Details

checks / integration tests (docker-stable) (pull_request) Successful in 10m35s

Details

issue-labels / release-notes (pull_request_target) Successful in 6s

Details

cascade / debug (pull_request_target) Has been skipped

Details

cascade / end-to-end (pull_request_target) Successful in 7s

Details

cascade / forgejo (pull_request_target) Successful in 1m41s

Details

ebb0c4f52a

feat: add connections to Runner configuration

checks / validate pre-commit-hooks file (pull_request) Successful in 1m0s

Details

checks / Build Forgejo Runner (pull_request) Successful in 1m21s

Details

checks / validate mocks (pull_request) Successful in 1m30s

Details

checks / runner exec tests (pull_request) Successful in 48s

Details

checks / Build unsupported platforms (pull_request) Successful in 1m14s

Details

issue-labels / release-notes (pull_request_target) Successful in 5s

Details

checks / integration tests (docker-latest) (pull_request) Successful in 12m41s

Details

checks / integration tests (docker-stable) (pull_request) Successful in 15m2s

Details

803834ba3f

aahlenst commented

2026-02-15 17:10:26 +00:00

Attention: stacked on top of #1377.

Questions/notes:

Connections is a map. Helps generating better diagnostics if multiple connections are present and one is invalid. Advantage of the map: YAML enforces that names are unqiue.
Labels are present on each connection, thereby matching .runner. The Runner administrator might not want to make every label available on every connection. Furthermore, different Forgejo instances might have labels with different meanings.
Same question regarding naming as in #1377.
Should label be an object? Could help if plan on expanding the configuration options for labels. I lean towards no.
The connections aren't used yet. I think it makes more sense to switch over while implementing polling of multiple Forgejo instances.

Attention: stacked on top of https://code.forgejo.org/forgejo/runner/pulls/1377. Questions/notes: * `Connections` is a map. Helps generating better diagnostics if multiple connections are present and one is invalid. Advantage of the map: YAML enforces that names are unqiue. * Labels are present on each connection, thereby matching `.runner`. The Runner administrator might not want to make every label available on every connection. Furthermore, different Forgejo instances might have labels with different meanings. * Same question regarding naming as in https://code.forgejo.org/forgejo/runner/pulls/1377. * Should `label` be an object? Could help if plan on expanding the configuration options for labels. I lean towards no. * The connections aren't used yet. I think it makes more sense to switch over while implementing polling of multiple Forgejo instances.

mfenniak commented

2026-02-16 02:27:45 +00:00

@aahlenst wrote in #1378 (comment):

* Should `label` be an object? Could help if plan on expanding the configuration options for labels. I lean towards no.

Sure, simple. 👍 I feel this is coming at some point but if we can avoid it, I'm happy.

* The connections aren't used yet. I think it makes more sense to switch over while implementing polling of multiple Forgejo instances.

Sounds good.

@aahlenst wrote in https://code.forgejo.org/forgejo/runner/pulls/1378#issuecomment-78074: > * Should `label` be an object? Could help if plan on expanding the configuration options for labels. I lean towards no. Sure, simple. 👍 I feel this is coming at some point but if we can avoid it, I'm happy. > * The connections aren't used yet. I think it makes more sense to switch over while implementing polling of multiple Forgejo instances. Sounds good.

mfenniak approved these changes

2026-02-16 02:28:11 +00:00

internal/pkg/config/config.go Outdated

					
				@ -42,0 +85,4 @@

				// Connection defines a connection to a Forgejo instance.

				type Connection struct {

					URL    *url.URL      // URL of the Forgejo instance to connect to. Mandatory value.