forgejo/runner
31
87
Fork 91
Code Issues 37 Pull requests 8 Releases 81 Packages 1 Activity Actions

refactor: pull cache server management out of runner #1373

Merged
mfenniak merged 2 commits from mfenniak/forgejo-runner:multiconnection-cache-server into main 2026-02-13 19:55:05 +00:00
Conversation 2 Commits 2 Files changed 8 +102 -45
mfenniak commented 2026-02-13 03:15:42 +00:00
Owner
Copy link

When NewRunner is invoked, it creates a Runner which does client-specific configuration -- environment variables GITHUB_SERVER_URL, ACTIONS_RUNTIME_URL, and ACTIONS_RESULTS_URL are all different based upon the connection address to the remote client. If we're going to support multiple connections to different servers, we're going to need multiple runners with these different environments. NewRunner also creates the cache server.

This PR pulls the cache server creation out of NewRunner so that multiple runners could be created.

  • other
    • PR: refactor: pull cache server management out of runner
When `NewRunner` is invoked, it creates a `Runner` which does client-specific configuration -- environment variables `GITHUB_SERVER_URL`, `ACTIONS_RUNTIME_URL`, and `ACTIONS_RESULTS_URL` are all different based upon the connection address to the remote client. If we're going to support multiple connections to different servers, we're going to need multiple runners with these different environments. `NewRunner` also creates the cache server. This PR pulls the cache server creation out of `NewRunner` so that multiple runners could be created. <!--start release-notes-assistant--> <!--URL:https://code.forgejo.org/forgejo/runner--> - other - [PR](https://code.forgejo.org/forgejo/runner/pulls/1373): <!--number 1373 --><!--line 0 --><!--description cmVmYWN0b3I6IHB1bGwgY2FjaGUgc2VydmVyIG1hbmFnZW1lbnQgb3V0IG9mIHJ1bm5lcg==-->refactor: pull cache server management out of runner<!--description--> <!--end release-notes-assistant-->
refactor: pull cache server mgmt out of runner
Some checks failed
issue-labels / release-notes (pull_request_target) Successful in 8s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 35s
Details
checks / Build Forgejo Runner (pull_request) Successful in 40s
Details
checks / validate mocks (pull_request) Successful in 46s
Details
checks / Build unsupported platforms (pull_request) Successful in 30s
Details
checks / runner exec tests (pull_request) Successful in 36s
Details
checks / integration tests (docker-latest) (pull_request) Failing after 9m39s
Details
checks / integration tests (docker-stable) (pull_request) Failing after 11m42s
Details
b86773193c
mfenniak changed title from refactor: pull cache server mgmt out of runner to refactor: pull cache server management out of runner 2026-02-13 03:15:49 +00:00
mfenniak force-pushed multiconnection-cache-server from b86773193c
Some checks failed
issue-labels / release-notes (pull_request_target) Successful in 8s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 35s
Details
checks / Build Forgejo Runner (pull_request) Successful in 40s
Details
checks / validate mocks (pull_request) Successful in 46s
Details
checks / Build unsupported platforms (pull_request) Successful in 30s
Details
checks / runner exec tests (pull_request) Successful in 36s
Details
checks / integration tests (docker-latest) (pull_request) Failing after 9m39s
Details
checks / integration tests (docker-stable) (pull_request) Failing after 11m42s
Details
to cedd332924
Some checks failed
cascade / debug (pull_request_target) Has been skipped
Details
cascade / forgejo (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 7s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 33s
Details
checks / Build Forgejo Runner (pull_request) Successful in 38s
Details
checks / validate mocks (pull_request) Successful in 40s
Details
checks / Build unsupported platforms (pull_request) Successful in 16s
Details
checks / runner exec tests (pull_request) Successful in 35s
Details
checks / integration tests (docker-stable) (pull_request) Failing after 12m43s
Details
checks / integration tests (docker-latest) (pull_request) Failing after 10m17s
Details
2026-02-13 03:28:56 +00:00 Compare
mfenniak force-pushed multiconnection-cache-server from cedd332924
Some checks failed
cascade / debug (pull_request_target) Has been skipped
Details
cascade / forgejo (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 7s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 33s
Details
checks / Build Forgejo Runner (pull_request) Successful in 38s
Details
checks / validate mocks (pull_request) Successful in 40s
Details
checks / Build unsupported platforms (pull_request) Successful in 16s
Details
checks / runner exec tests (pull_request) Successful in 35s
Details
checks / integration tests (docker-stable) (pull_request) Failing after 12m43s
Details
checks / integration tests (docker-latest) (pull_request) Failing after 10m17s
Details
to 5252141855
Some checks failed
cascade / end-to-end (pull_request_target) Has been skipped
Details
cascade / forgejo (pull_request_target) Has been skipped
Details
cascade / debug (pull_request_target) Has been skipped
Details
issue-labels / release-notes (pull_request_target) Successful in 7s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 42s
Details
checks / validate mocks (pull_request) Successful in 51s
Details
checks / Build Forgejo Runner (pull_request) Successful in 1m42s
Details
checks / Build unsupported platforms (pull_request) Successful in 40s
Details
checks / runner exec tests (pull_request) Successful in 54s
Details
checks / integration tests (docker-latest) (pull_request) Failing after 9m52s
Details
checks / integration tests (docker-stable) (pull_request) Failing after 11m55s
Details
2026-02-13 03:58:44 +00:00 Compare
aahlenst approved these changes 2026-02-13 12:52:21 +00:00
internal/app/run/runner.go
@ -76,2 +73,2 @@
} else {
cacheProxy = nil
if cacheProxy != nil {
envs["ACTIONS_CACHE_URL"] = cacheProxy.ExternalURL()
aahlenst commented 2026-02-13 12:52:16 +00:00
Member
Copy link

Is there an advantage to passing the entire handler to NewRunner if only the external URL is necessary? I see that typing is better (unless you can pass net.URL), but it needs a mock during testing.

Is there an advantage to passing the entire handler to `NewRunner` if only the external URL is necessary? I see that typing is better (unless you can pass `net.URL`), but it needs a mock during testing.
mfenniak commented 2026-02-13 18:50:37 +00:00
Author
Owner
Copy link

The URL isn't the only usage -- the cacheProxy is stored on the runner, and it is used to register new runs with the proxy when they start.

The URL isn't the only usage -- the `cacheProxy` is stored on the runner, and it is used to register new runs with the proxy when they start.
aahlenst commented 2026-02-13 20:10:02 +00:00
Member
Copy link

Sometimes, I don't see things that stare me in the face 🤦

Sometimes, I don't see things that stare me in the face 🤦
😆 1
aahlenst marked this conversation as resolved
refactor: close artifactcache when closing cacheproxy, if running internal server
All checks were successful
checks / Build Forgejo Runner (pull_request) Successful in 24s
Details
checks / validate pre-commit-hooks file (pull_request) Successful in 30s
Details
checks / validate mocks (pull_request) Successful in 38s
Details
checks / Build unsupported platforms (pull_request) Successful in 23s
Details
checks / runner exec tests (pull_request) Successful in 34s
Details
checks / integration tests (docker-latest) (pull_request) Successful in 9m4s
Details
checks / integration tests (docker-stable) (pull_request) Successful in 11m0s
Details
issue-labels / release-notes (pull_request_target) Successful in 3s
Details
cascade / debug (pull_request_target) Has been skipped
Details
cascade / end-to-end (pull_request_target) Successful in 4s
Details
cascade / forgejo (pull_request_target) Successful in 1m8s
Details
b717875be4
cascading-pr commented 2026-02-13 18:56:45 +00:00
Contributor
Copy link

cascading-pr updated at actions/setup-forgejo#885

cascading-pr updated at https://code.forgejo.org/actions/setup-forgejo/pulls/885
mfenniak deleted branch multiconnection-cache-server 2026-02-13 19:55:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aahlenst
Labels
Clear labels   
FreeBSD

   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Chore

It is no fun but it needs to be done, this is a chore.

  
Kind/DependencyUpdate

for pull requests that are created by renovate when updating a dependency

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Windows

Windows ports is an independent project, see https://github.com/Crown0815/Forgejo-runner-windows-builder

  
linux-powerpc64le

powerpc64le

  
linux-riscv64

   
linux-s390x

   
run-end-to-end-tests

Run https://code.forgejo.org/forgejo/end-to-end with a runner compiled from this pull request

  
run-forgejo-tests

Run https://codeberg.org/forgejo/forgejo tests importing the runner from this pull request

No labels
FreeBSD
Kind/Breaking
Kind/Bug
Kind/Chore
Kind/DependencyUpdate
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Windows
linux-powerpc64le
linux-riscv64
linux-s390x
run-end-to-end-tests
run-forgejo-tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/runner!1373
No description provided.