fix: premature task completion when chaining multiple reusable workflows #1367

Merged

mfenniak merged 1 commit from syncstack/runner:fix/nested-reusable-workflow-task-finalization into main

2026-02-11 20:27:24 +00:00

syncstack commented

2026-02-10 19:28:56 +00:00

Contributor

Example

# repo: my-project/.workflows/ci.yml
jobs:
  pipeline:
    uses: shared-workflows/.workflows/pipeline.yml@main

# repo: shared-workflows/.workflows/pipeline.yml
jobs:
  step-a:
    uses: shared-workflows/.workflows/step-a.yml@v1

  step-b:
    needs: [step-a]
    uses: shared-workflows/.workflows/step-b.yml@v1
    # ^ At first glance this appears to work — steps execute and logs
    #   are streamed — but the runner has already finalized the task
    #   after step-a completed. The log stream is silently writing into
    #   a task that Forgejo considers finished.
    #
    #   The problem becomes visible when step-b tries to interact with
    #   the Forgejo API (e.g. uploading artifacts, updating status):
    #   those calls fail with "task is not running" and artifacts are
    #   lost. The parent workflow also reports success regardless of
    #   what actually happened in step-b.

bug fixes
- PR: fix: premature task completion when chaining multiple reusable workflows

When a workflow calls a reusable workflow that itself chains two or more reusable workflows sequentially, the runner incorrectly marks the overall task as completed after the first nested reusable workflow finishes. ### Example ```yaml # repo: my-project/.workflows/ci.yml jobs: pipeline: uses: shared-workflows/.workflows/pipeline.yml@main ``` ```yaml # repo: shared-workflows/.workflows/pipeline.yml jobs: step-a: uses: shared-workflows/.workflows/step-a.yml@v1 step-b: needs: [step-a] uses: shared-workflows/.workflows/step-b.yml@v1 # ^ At first glance this appears to work — steps execute and logs # are streamed — but the runner has already finalized the task # after step-a completed. The log stream is silently writing into # a task that Forgejo considers finished. # # The problem becomes visible when step-b tries to interact with # the Forgejo API (e.g. uploading artifacts, updating status): # those calls fail with "task is not running" and artifacts are # lost. The parent workflow also reports success regardless of # what actually happened in step-b. ```   - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1367): fix: premature task completion when chaining multiple reusable workflows

syncstack added 1 commit

2026-02-10 19:28:56 +00:00

fix(ReusableWorkflowRunner): skip banner for nested reusable workflows

checks / validate pre-commit-hooks file (pull_request) Successful in 33s

Details

checks / Build Forgejo Runner (pull_request) Successful in 37s

Details

checks / validate mocks (pull_request) Successful in 38s

Details

checks / Build unsupported platforms (pull_request) Successful in 20s

Details

checks / runner exec tests (pull_request) Successful in 26s

Details

checks / integration tests (docker-latest) (pull_request) Successful in 7m46s

Details

checks / integration tests (docker-stable) (pull_request) Successful in 10m15s

Details

issue-labels / release-notes (pull_request_target) Successful in 4s

Details

cascade / debug (pull_request_target) Has been skipped

Details

cascade / end-to-end (pull_request_target) Successful in 4s

Details

cascade / forgejo (pull_request_target) Successful in 23s

Details

132bb2aa27

syncstack changed title from ~~WIP: fix premature task completion when chaining multiple reusable workflows~~ to fix premature task completion when chaining multiple reusable workflows

2026-02-11 06:28:56 +00:00

syncstack changed title from ~~fix premature task completion when chaining multiple reusable workflows~~ to fix: premature task completion when chaining multiple reusable workflows

2026-02-11 06:29:32 +00:00