Alert users that defaults are used when --config is not provided.

gordonmessmer commented

2026-02-06 01:14:41 +00:00

Contributor

other
- PR: Alert users that defaults are used when --config is not provided.

- other - [PR](https://code.forgejo.org/forgejo/runner/pulls/1352): Alert users that defaults are used when --config is not provided.

aahlenst commented

2026-02-06 07:29:12 +00:00

Member

What is your motivation for this change?

Using Forgejo Runner without a configuration file is expected and supported.

What is your motivation for this change? Using Forgejo Runner without a configuration file is expected and supported.

gordonmessmer commented

2026-02-07 04:42:13 +00:00

Author

Contributor

What is your motivation for this change?

If a user runs forgejo-runner generate-config, the program will inform them that they can "just run forgejo-runner generate-config > config.yaml to generate a config file."

I think it is not intuitive that forgejo-runner register will create a .runner file, which is used automatically, but forgejo-runner generate-config > config.yaml will create a configuration file that is not used automatically.

Using Forgejo Runner without a configuration file is expected and supported.

Yes, of course. This PR doesn't change that, it merely prints a notice that the runner is using its default configuration.

Would log.Info be better for this purpose?

> What is your motivation for this change? If a user runs `forgejo-runner generate-config`, the program will inform them that they can "just run `forgejo-runner generate-config > config.yaml` to generate a config file." I think it is not intuitive that `forgejo-runner register` will create a .runner file, which is used automatically, but `forgejo-runner generate-config > config.yaml` will create a configuration file that is not used automatically. > Using Forgejo Runner without a configuration file is expected and supported. Yes, of course. This PR doesn't change that, it merely prints a notice that the runner is using its default configuration. Would `log.Info` be better for this purpose?

aahlenst commented

2026-02-07 10:56:41 +00:00

Member

@gordonmessmer wrote in #1352 (comment):

I think it is not intuitive that forgejo-runner register will create a .runner file, which is used automatically, but forgejo-runner generate-config > config.yaml will create a configuration file that is not used automatically.

For context, .runner is internal state, not configuration.

So far, I don't know what the right course of action is. I agree that the current situation is not ideal. If you're interested, forgejo/forgejo-actions-feature-requests#88 gives you the boring details.

Proposal 1: Turn the warning into an info message. Then, I'm fine with merging it. But don't be surprised if it disappears again, depending on what we're going to do in this area. But feel free to complain again.

Proposal 2: Abandon this PR and wait for the big configuration change.

@gordonmessmer wrote in https://code.forgejo.org/forgejo/runner/pulls/1352#issuecomment-77156: > I think it is not intuitive that `forgejo-runner register` will create a .runner file, which is used automatically, but `forgejo-runner generate-config > config.yaml` will create a configuration file that is not used automatically. For context, `.runner` is internal state, not configuration. So far, I don't know what the right course of action is. I agree that the current situation is not ideal. If you're interested, https://code.forgejo.org/forgejo/forgejo-actions-feature-requests/issues/88 gives you the boring details. Proposal 1: Turn the warning into an info message. Then, I'm fine with merging it. But don't be surprised if it disappears again, depending on what we're going to do in this area. But feel free to complain again. Proposal 2: Abandon this PR and wait for the big configuration change.

mfenniak commented

2026-02-07 16:26:53 +00:00

Owner

I like the idea of an info message to help highlight the issue for the unsuspecting. It happens frequently, and this could help identify it occasionally. 👍