fix: inputs containing '-' don't function in LXC executor #1336

Merged

mfenniak merged 1 commit from mfenniak/forgejo-runner:fix-lxc-hyphen into main

2026-01-26 01:30:49 +00:00

mfenniak commented

2026-01-25 19:29:30 +00:00

Owner

Due to a dependency update failure in #1331, I was able to identify that #1287 introduced a regression in handling inputs that contain hyphens (-) in them. With actions that are executed as using: node20 (and similar), inputs are provided as environment variables, such as INPUT_KEEP-STATE for an input keep-state.

As part of replacing lxc-enter with nsenter, a small shell script with /bin/sh was used to change the current process's cgroup to .lxc, matching the lxc-enter behaviour. Experimentally, /bin/sh was found to strip out the INPUT_KEEP-STATE environment variable. This fix replaces /bin/sh with /usr/bin/bash. Note that pathing does not need to be dynamic (eg. no need to do /usr/bin/env bash) because the LXC environment supports Debian Bookworm & Trixie only at this time.

I've verified that I can reproduce the error identified in #1331 and that this fix continues past that error in release testing simulation.

The regression in behaviour is present in runner v12.6.0 & v12.6.1.

bug fixes
- PR: fix: inputs containing '-' don't function in LXC executor

Due to a dependency update failure in #1331, I was able to identify that #1287 introduced a regression in handling inputs that contain hyphens (`-`) in them. With actions that are executed as `using: node20` (and similar), inputs are provided as environment variables, such as `INPUT_KEEP-STATE` for an input `keep-state`. As part of replacing `lxc-enter` with `nsenter`, a small shell script with `/bin/sh` was used to change the current process's cgroup to `.lxc`, matching the `lxc-enter` behaviour. Experimentally, `/bin/sh` was found to strip out the `INPUT_KEEP-STATE` environment variable. This fix replaces `/bin/sh` with `/usr/bin/bash`. Note that pathing does not need to be dynamic (eg. no need to do `/usr/bin/env bash`) because the LXC environment supports Debian Bookworm & Trixie only at this time. I've verified that I can reproduce the error identified in #1331 and that this fix continues past that error in release testing simulation. The regression in behaviour is present in runner v12.6.0 & v12.6.1.   - bug fixes - [PR](https://code.forgejo.org/forgejo/runner/pulls/1336): fix: inputs containing '-' don't function in LXC executor

mfenniak added 1 commit

2026-01-25 19:29:30 +00:00